From feed74f3bd032f25bae6456005fcb312544ddcb4 Mon Sep 17 00:00:00 2001 From: Daniel Stockman Date: Tue, 19 Feb 2013 15:07:38 -0800 Subject: [PATCH] Fallback url() value for data-uri function should be quoted. --- lib/less/functions.js | 2 +- test/css/urls.css | 2 +- test/less/urls.less | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/less/functions.js b/lib/less/functions.js index f987bb6f..da907568 100644 --- a/lib/less/functions.js +++ b/lib/less/functions.js @@ -429,7 +429,7 @@ tree.functions = { console.warn("Skipped data-uri embedding of %s because its size (%dKB) exceeds IE8-safe %dKB!", filePath, fileSizeInKB, DATA_URI_MAX_KB); } - return new(tree.URL)(new(tree.Anonymous)(filePath)); + return new(tree.URL)(new(tree.Quoted)("'" + filePath + "'", filePath)); } else if (!this.env.silent) { // if explicitly disabled (via --no-ie-compat on CLI, or env.ieCompat === false), merely warn console.warn("WARNING: Embedding %s (%dKB) exceeds IE8's data-uri size limit of %dKB!", filePath, fileSizeInKB, DATA_URI_MAX_KB); diff --git a/test/css/urls.css b/test/css/urls.css index 1226e4d8..a43d95de 100644 --- a/test/css/urls.css +++ b/test/css/urls.css @@ -53,5 +53,5 @@ uri-2: url('data:text/html,%3Ch1%3EThis%20page%20is%20100%25%20Awesome.%3C%2Fh1%3E%0A'); } #data-uri-toobig { - uri: url(../data/data-uri-fail.png); + uri: url('../data/data-uri-fail.png'); } diff --git a/test/less/urls.less b/test/less/urls.less index a047cc85..e80af254 100644 --- a/test/less/urls.less +++ b/test/less/urls.less @@ -47,7 +47,6 @@ uri-2: data-uri('../data/page.html'); } -// so, weirdly, the browser output is quoted, the less output is UNquoted #data-uri-toobig { uri: data-uri('../data/data-uri-fail.png'); }