From 9f78c9dad8200fc72e3f1ecca78647d4019673c0 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 13 Mar 2025 14:47:22 +0100 Subject: [PATCH] chore: fix broken type check for test files (#7567) **Motivation** Check the types for test files **Description** - Add `test` folder for the `tsconfig.json` files **Steps to test or reproduce** - Run all tests --- packages/api/tsconfig.json | 2 +- .../test/e2e/eth1/eth1ForBlockProduction.test.ts | 2 -- packages/beacon-node/test/tsconfig.json | 6 ------ packages/beacon-node/tsconfig.json | 2 +- packages/cli/tsconfig.json | 2 +- packages/config/tsconfig.json | 2 +- packages/db/tsconfig.json | 2 +- packages/flare/tsconfig.json | 2 +- packages/fork-choice/tsconfig.json | 2 +- packages/light-client/tsconfig.json | 1 + packages/logger/tsconfig.json | 2 +- packages/params/tsconfig.json | 2 +- packages/prover/test/tsconfig.json | 6 ------ packages/prover/tsconfig.json | 6 +++--- packages/reqresp/tsconfig.json | 13 ++++--------- packages/spec-test-util/tsconfig.json | 2 +- packages/state-transition/tsconfig.json | 2 +- packages/test-utils/tsconfig.json | 2 +- packages/types/tsconfig.json | 2 +- packages/utils/tsconfig.json | 2 +- packages/validator/tsconfig.json | 2 +- tsconfig.json | 4 +--- 22 files changed, 24 insertions(+), 44 deletions(-) delete mode 100644 packages/beacon-node/test/tsconfig.json delete mode 100644 packages/prover/test/tsconfig.json diff --git a/packages/api/tsconfig.json b/packages/api/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/api/tsconfig.json +++ b/packages/api/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts b/packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts index f72be5ed3e..f5d4920a35 100644 --- a/packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts +++ b/packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts @@ -32,7 +32,6 @@ describe.skip("eth1 / Eth1Provider", () => { const logger = testLogger(); let db: BeaconDb; - let interval: NodeJS.Timeout; beforeAll(async () => { // Nuke DB to make sure it's empty @@ -42,7 +41,6 @@ describe.skip("eth1 / Eth1Provider", () => { }); afterAll(async () => { - clearInterval(interval); controller.abort(); await db.close(); await LevelDbController.destroy(dbLocation); diff --git a/packages/beacon-node/test/tsconfig.json b/packages/beacon-node/test/tsconfig.json deleted file mode 100644 index f4241fc1fb..0000000000 --- a/packages/beacon-node/test/tsconfig.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../tsconfig", - "compilerOptions": { - "noEmit": false - } -} diff --git a/packages/beacon-node/tsconfig.json b/packages/beacon-node/tsconfig.json index 69319f7365..d1c8b717b5 100644 --- a/packages/beacon-node/tsconfig.json +++ b/packages/beacon-node/tsconfig.json @@ -1,7 +1,7 @@ { "extends": "../../tsconfig.json", "exclude": ["../../node_modules/it-pipe"], - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/cli/tsconfig.json b/packages/cli/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/cli/tsconfig.json +++ b/packages/cli/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/config/tsconfig.json b/packages/config/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/config/tsconfig.json +++ b/packages/config/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/db/tsconfig.json b/packages/db/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/db/tsconfig.json +++ b/packages/db/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/flare/tsconfig.json b/packages/flare/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/flare/tsconfig.json +++ b/packages/flare/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/fork-choice/tsconfig.json b/packages/fork-choice/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/fork-choice/tsconfig.json +++ b/packages/fork-choice/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/light-client/tsconfig.json b/packages/light-client/tsconfig.json index 2e29400b48..c2ec15e13d 100644 --- a/packages/light-client/tsconfig.json +++ b/packages/light-client/tsconfig.json @@ -1,4 +1,5 @@ { "extends": "../../tsconfig.json", + "include": ["src", "test"], "exclude": ["src/index.browser.ts", "test/unit/webEsmBundle.browser.test.ts"] } diff --git a/packages/logger/tsconfig.json b/packages/logger/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/logger/tsconfig.json +++ b/packages/logger/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/params/tsconfig.json b/packages/params/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/params/tsconfig.json +++ b/packages/params/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/prover/test/tsconfig.json b/packages/prover/test/tsconfig.json deleted file mode 100644 index f4241fc1fb..0000000000 --- a/packages/prover/test/tsconfig.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../tsconfig", - "compilerOptions": { - "noEmit": false - } -} diff --git a/packages/prover/tsconfig.json b/packages/prover/tsconfig.json index 8caa44a01b..115d91d4c4 100644 --- a/packages/prover/tsconfig.json +++ b/packages/prover/tsconfig.json @@ -1,10 +1,10 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { // To fix error "Duplicate identifier 'Buffer'" - // This can save time during compilation at the expense of type-system accuracy. - // For example, two libraries could define two copies of the same type in an inconsistent way. + // This can save time during compilation at the expense of type-system accuracy. + // For example, two libraries could define two copies of the same type in an inconsistent way. // Rather than doing a full check of all d.ts files, TypeScript will type check // the code you specifically refer to in your app’s source code. // https://www.typescriptlang.org/tsconfig#skipLibCheck diff --git a/packages/reqresp/tsconfig.json b/packages/reqresp/tsconfig.json index ed991a667e..9e7b19564a 100644 --- a/packages/reqresp/tsconfig.json +++ b/packages/reqresp/tsconfig.json @@ -1,14 +1,9 @@ { "extends": "../../tsconfig.json", - "include": ["src"], - "exclude": [ - "../../node_modules/it-pipe" - ], + "include": ["src", "test"], + "exclude": ["../../node_modules/it-pipe"], "compilerOptions": { "outDir": "lib", - "typeRoots": [ - "../../node_modules/@types", - "../../types" - ] + "typeRoots": ["../../node_modules/@types", "../../types"] } -} \ No newline at end of file +} diff --git a/packages/spec-test-util/tsconfig.json b/packages/spec-test-util/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/spec-test-util/tsconfig.json +++ b/packages/spec-test-util/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/state-transition/tsconfig.json b/packages/state-transition/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/state-transition/tsconfig.json +++ b/packages/state-transition/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/test-utils/tsconfig.json b/packages/test-utils/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/test-utils/tsconfig.json +++ b/packages/test-utils/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/types/tsconfig.json b/packages/types/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/types/tsconfig.json +++ b/packages/types/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/utils/tsconfig.json b/packages/utils/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/utils/tsconfig.json +++ b/packages/utils/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/packages/validator/tsconfig.json b/packages/validator/tsconfig.json index f9bd78a3fa..a0f4f2a31e 100644 --- a/packages/validator/tsconfig.json +++ b/packages/validator/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../tsconfig.json", - "include": ["src"], + "include": ["src", "test"], "compilerOptions": { "outDir": "lib" } diff --git a/tsconfig.json b/tsconfig.json index 6e1e1901b5..bfb4417ff6 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -3,8 +3,6 @@ "compilerOptions": { "emitDeclarationOnly": false, "incremental": false, - // Enable it when upgrade `vite-plugin-dts` - // "noCheck": false, "noEmit": true, // To be used in the test fixtures "resolveJsonModule": true, @@ -16,4 +14,4 @@ "ts-node": { "transpileOnly": true } -} \ No newline at end of file +}