From addc889052c25ffee3d8883ce0c021b7057b31f7 Mon Sep 17 00:00:00 2001 From: Dominik Ferber Date: Tue, 20 Oct 2015 23:15:34 +0200 Subject: [PATCH 1/2] fix(methods): Restirct warnings on NewExpressions to Meteor.Error Previously the rule would warn on all NewExpressions with no arguments. --- lib/rules/methods.js | 7 ++++++- tests/lib/rules/methods.js | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/rules/methods.js b/lib/rules/methods.js index 1cb0245880..075087f042 100644 --- a/lib/rules/methods.js +++ b/lib/rules/methods.js @@ -8,7 +8,7 @@ import {NON_METEOR} from '../util/environment' import {getExecutors} from '../util' -import {isMeteorCall, getPropertyName, refersTo, hasContext} from '../util/ast' +import {isMeteorCall, isMeteorProp, getPropertyName, refersTo, hasContext} from '../util/ast' // ----------------------------------------------------------------------------- // Rule Definition @@ -117,6 +117,11 @@ module.exports = getMeta => context => { return { NewExpression: function (node) { + + if (!isMeteorProp(node.callee, 'Error')) { + return + } + const executors = getExecutors(env, context.getAncestors()) if (executors.size === 0) { return diff --git a/tests/lib/rules/methods.js b/tests/lib/rules/methods.js index 3f131d020c..76fdb05f99 100644 --- a/tests/lib/rules/methods.js +++ b/tests/lib/rules/methods.js @@ -14,6 +14,7 @@ const rule = require('../../../dist/rules/methods') const RuleTester = require('eslint').RuleTester const commonValidCode = [ + 'new Meteor.foo()', 'Meteor.call("foo")', 'Meteor.call("foo", true)', 'Meteor.apply("foo", [], function () {})', From 52569bf04473468c680766bb4ff28a66d1db4d3d Mon Sep 17 00:00:00 2001 From: greenkeeperio-bot Date: Wed, 21 Oct 2015 19:18:37 +0200 Subject: [PATCH 2/2] chore(package): update eslint to version 1.7.3 http://greenkeeper.io/ --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 454e8e3bc2..7db6c725ca 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "colors": "1.1.2", "coveralls": "2.11.4", "cz-conventional-changelog": "1.1.4", - "eslint": "1.7.2", + "eslint": "1.7.3", "ghooks": "0.3.2", "istanbul": "0.4.0", "mocha": "2.3.3",