From 147ef71195bceac78a81d17bf9a89b246eafaa85 Mon Sep 17 00:00:00 2001 From: Avital Oliver Date: Mon, 8 Oct 2012 13:26:50 -0700 Subject: [PATCH] Large refactor of accounts-ui - Split login_buttons.html and login_buttons.js into multiple files - Specifically, make it easier to reason about the display of loginButtons whether it is in dropdown mode or not - Split templates into subtemplates to make it easier to read the login button .html files as "tables of contents" - Introduce Meteor._loginButtonsSession, which makes it easier to access internal session fields for loginButtons - Unify code that calls the various Meteor.loginWithFoo() functions Breaking change: rename "configureLoginServicesDialogForFoo" to "configureLoginServiceDialogForFoo" (in packages such as accounts-facebook) --- .../accounts-facebook/facebook_configure.html | 2 +- .../accounts-facebook/facebook_configure.js | 4 +- .../accounts-github/github_configure.html | 2 +- packages/accounts-github/github_configure.js | 4 +- .../accounts-google/google_configure.html | 2 +- packages/accounts-google/google_configure.js | 4 +- .../accounts-password/passwords_client.js | 2 + .../accounts-twitter/twitter_configure.html | 2 +- .../accounts-twitter/twitter_configure.js | 4 +- .../accounts-ui-unstyled/login_buttons.html | 296 +------ .../accounts-ui-unstyled/login_buttons.js | 814 ++---------------- .../login_buttons_dialogs.html | 122 +++ .../login_buttons_dialogs.js | 234 +++++ .../login_buttons_dropdown.html | 145 ++++ .../login_buttons_dropdown.js | 414 +++++++++ .../login_buttons_session.js | 60 ++ .../login_buttons_single.html | 11 + .../login_buttons_single.js | 40 + packages/accounts-ui-unstyled/package.js | 11 +- packages/accounts-ui/login_buttons.less | 33 +- packages/accounts-weibo/weibo_configure.html | 2 +- packages/accounts-weibo/weibo_configure.js | 4 +- 22 files changed, 1147 insertions(+), 1065 deletions(-) create mode 100644 packages/accounts-ui-unstyled/login_buttons_dialogs.html create mode 100644 packages/accounts-ui-unstyled/login_buttons_dialogs.js create mode 100644 packages/accounts-ui-unstyled/login_buttons_dropdown.html create mode 100644 packages/accounts-ui-unstyled/login_buttons_dropdown.js create mode 100644 packages/accounts-ui-unstyled/login_buttons_session.js create mode 100644 packages/accounts-ui-unstyled/login_buttons_single.html create mode 100644 packages/accounts-ui-unstyled/login_buttons_single.js diff --git a/packages/accounts-facebook/facebook_configure.html b/packages/accounts-facebook/facebook_configure.html index c24b24b823..aa0344a8c9 100644 --- a/packages/accounts-facebook/facebook_configure.html +++ b/packages/accounts-facebook/facebook_configure.html @@ -1,4 +1,4 @@ -