From 6bb10c8693ade3982bdb39bd52c324d10a1700c1 Mon Sep 17 00:00:00 2001 From: Zack Date: Tue, 20 Apr 2021 09:21:42 -0400 Subject: [PATCH 1/7] Update oplog_tailing.js Switch Timestamp.ONE to Long.ONE --- packages/mongo/oplog_tailing.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/mongo/oplog_tailing.js b/packages/mongo/oplog_tailing.js index 7d2b2fea10..698e9ce4c0 100644 --- a/packages/mongo/oplog_tailing.js +++ b/packages/mongo/oplog_tailing.js @@ -1,7 +1,7 @@ var Future = Npm.require('fibers/future'); import { NpmModuleMongodb } from "meteor/npm-mongo"; -const { Timestamp } = NpmModuleMongodb; +const { Long } = NpmModuleMongodb; OPLOG_COLLECTION = 'oplog.rs'; @@ -278,7 +278,7 @@ _.extend(OplogHandle.prototype, { // See https://github.com/meteor/meteor/issues/10420. if (!op.ts) { op.ts = nextTimestamp; - nextTimestamp = nextTimestamp.add(Timestamp.ONE); + nextTimestamp = nextTimestamp.add(Long.ONE); } handleDoc(op); }); From 66f0467caacd18a552264f5d5b70029c32e5c8f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rados=C5=82aw=20Miernik?= Date: Mon, 26 Apr 2021 08:51:57 +0200 Subject: [PATCH 2/7] Reordered fields in DDP method call. --- packages/ddp-client/common/livedata_connection.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ddp-client/common/livedata_connection.js b/packages/ddp-client/common/livedata_connection.js index 740a7f4abb..f3992944c2 100644 --- a/packages/ddp-client/common/livedata_connection.js +++ b/packages/ddp-client/common/livedata_connection.js @@ -692,9 +692,9 @@ export class Connection { // wrote. const message = { msg: 'method', + id: methodId, method: name, - params: args, - id: methodId + params: args }; // If an exception occurred in a stub, and we're ignoring it From 55974a420a67032cafc413d7207e96296bf79ee6 Mon Sep 17 00:00:00 2001 From: Jan Dvorak Date: Wed, 28 Apr 2021 17:43:02 +0200 Subject: [PATCH 3/7] Improve password validator --- packages/accounts-password/package.js | 2 +- packages/accounts-password/password_server.js | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/accounts-password/package.js b/packages/accounts-password/package.js index c5656d6990..9109e5cc93 100644 --- a/packages/accounts-password/package.js +++ b/packages/accounts-password/package.js @@ -5,7 +5,7 @@ Package.describe({ // 2.2.x in the future. The version was also bumped to 2.0.0 temporarily // during the Meteor 1.5.1 release process, so versions 2.0.0-beta.2 // through -beta.5 and -rc.0 have already been published. - version: "1.7.0" + version: "1.7.1" }); Package.onUse(api => { diff --git a/packages/accounts-password/password_server.js b/packages/accounts-password/password_server.js index 2076985362..c09b7bb5f8 100644 --- a/packages/accounts-password/password_server.js +++ b/packages/accounts-password/password_server.js @@ -277,8 +277,10 @@ const userQueryValidator = Match.Where(user => { }); const passwordValidator = Match.OneOf( - String, - { digest: String, algorithm: String } + Match.Where(str => Match.test(str, String) && str.length <= Meteor.settings?.packages?.accounts?.passwordMaxLength || 256), { + digest: Match.Where(str => Match.test(str, String) && str.length === 64), + algorithm: Match.OneOf('sha-256') + } ); // Handler to login with a password. From 18acb613a38cc003e1b744d013693074710020b7 Mon Sep 17 00:00:00 2001 From: Jan Dvorak Date: Thu, 29 Apr 2021 19:38:05 +0200 Subject: [PATCH 4/7] Bump ddp-client version and add history entry --- History.md | 2 ++ packages/ddp-client/package.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/History.md b/History.md index ac14a8813e..185e615953 100644 --- a/History.md +++ b/History.md @@ -4,6 +4,8 @@ * Updated `ddp-server@2.3.3` and `socket-stream-client@0.3.2` dependencies which removes Node's HTTP deprecation warning. +* Released `ddp-client@2.4.1` re-ordering fields in DDP message for better client readability. + ## v2.2, 2021-04-15 #### Highlights diff --git a/packages/ddp-client/package.js b/packages/ddp-client/package.js index 1d5b5a5bcd..ff13d25b8e 100644 --- a/packages/ddp-client/package.js +++ b/packages/ddp-client/package.js @@ -1,6 +1,6 @@ Package.describe({ summary: "Meteor's latency-compensated distributed data client", - version: '2.4.0', + version: '2.4.1', documentation: null }); From 0b9feae1640aeddd256c59b9c52bc9c61cc28e27 Mon Sep 17 00:00:00 2001 From: Jan Dvorak Date: Fri, 30 Apr 2021 17:25:52 +0200 Subject: [PATCH 5/7] Published mongo@1.11.1 --- History.md | 2 ++ packages/mongo/package.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/History.md b/History.md index 185e615953..3405f4f551 100644 --- a/History.md +++ b/History.md @@ -6,6 +6,8 @@ * Released `ddp-client@2.4.1` re-ordering fields in DDP message for better client readability. +* Released `mongo@1.11.1` fixing a `Timestamp.ONE is undefined` bug. + ## v2.2, 2021-04-15 #### Highlights diff --git a/packages/mongo/package.js b/packages/mongo/package.js index 8be1541d3f..3a7807aca0 100644 --- a/packages/mongo/package.js +++ b/packages/mongo/package.js @@ -9,7 +9,7 @@ Package.describe({ summary: "Adaptor for using MongoDB and Minimongo over DDP", - version: '1.11.0' + version: '1.11.1' }); Npm.depends({ From 65a3be9065227ba11ab0680f85c109d99b860bb4 Mon Sep 17 00:00:00 2001 From: Jan Dvorak Date: Sun, 2 May 2021 14:34:31 +0200 Subject: [PATCH 6/7] Fix test-packages in browser testing --- tools/cli/default-npm-deps.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/cli/default-npm-deps.js b/tools/cli/default-npm-deps.js index b7a3392434..d34c1a702e 100644 --- a/tools/cli/default-npm-deps.js +++ b/tools/cli/default-npm-deps.js @@ -13,7 +13,8 @@ export function install(appDir, options) { const needTempPackageJson = ! statOrNull(packageJsonPath); if (needTempPackageJson) { - const { dependencies } = require("../static-assets/skel-minimal/package.json"); + // NOTE we need skel-minimal to pull in jQuery which right now is required for Blaze + const { dependencies } = require("../static-assets/skel-blaze/package.json"); // Write a minimial package.json with the same dependencies as the // default new-app package.json file. From 8c458636f1374be98a7999fa33a19decad3ca48b Mon Sep 17 00:00:00 2001 From: Jan Dvorak Date: Mon, 3 May 2021 12:54:48 +0200 Subject: [PATCH 7/7] Fix $mul tests for minimongo --- packages/minimongo/minimongo_tests_client.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/minimongo/minimongo_tests_client.js b/packages/minimongo/minimongo_tests_client.js index 95526acaea..1e369c8d06 100644 --- a/packages/minimongo/minimongo_tests_client.js +++ b/packages/minimongo/minimongo_tests_client.js @@ -2234,7 +2234,7 @@ Tinytest.add('minimongo - nested array sort', test => { c.insert({ ab0x: 6, ab0x_g: 6, g_ab0x: 6, cdx: 8, cdx_cdy: 8, cdy_cdx: 2, n: 6 , a: { b: [{ x: 2.5 }] }, c: { d: [{x: 2, y: 2}, {x: 3}] }, g: 4 }); c.insert({ ab0x: 7, ab0x_g: 7, g_ab0x: 7, cdx: 4, cdx_cdy: 4, cdy_cdx: 6, n: 7 , a: { b: [{ x: 5 }] }, c: { d: [{ y: 2}, { y: 3}] }, g: 5 }); c.insert({ ab0x: 8, ab0x_g: 8, g_ab0x: 8, cdx: 5, cdx_cdy: 5, cdy_cdx: 7, n: 8 , a: { b: [{ x: 6 }, { x: 7 }] }, c: { d: [{ y: 2}, { x: 1.5, y: 2}] }, g: 6 }); - + // Test that the the documents in "cursor" contain values with the name // "field" running from 0 to the max value of that name in the collection. const testCursorMatchesField = (cursor, field) => { @@ -2254,7 +2254,7 @@ Tinytest.add('minimongo - nested array sort', test => { testCursorMatchesField(c.find({}, { sort: { 'c.d.x': 1 } }), 'cdx'); testCursorMatchesField(c.find({}, { sort: { 'c.d.x': 1, 'c.d.y': 1 } }), 'cdx_cdy'); testCursorMatchesField(c.find({}, { sort: { 'c.d.y': 1, 'c.d.x': 1 } }), 'cdy_cdx'); - + }); Tinytest.add('minimongo - sort keys', test => { @@ -2312,7 +2312,7 @@ Tinytest.add('minimongo - sort keys', test => { testKeys({'a.0.x': 1}, {a: [{x: 0}]}, [[0]]); - + testKeys({'a.0.x': 1}, {a: []}, [[undefined]]); @@ -2673,10 +2673,10 @@ Tinytest.add('minimongo - modify', test => { exception({a: false}, {$mul: {a: 10}}); exception({a: null}, {$mul: {a: 10}}); exception({}, {$mul: {_id: 1}}); - modify({a: [1, 2]}, {$mul: {'a.1': 2}}, {a: [2, 1]}); - modify({a: [1, 2]}, {$mul: {'a.1': 3}}, {a: [3, 2]}); - modify({a: [1, 2]}, {$mul: {'a.2': 10}}, {a: [1, 20]}); - modify({a: [1, 2]}, {$mul: {'a.3': 10}}, {a: [1, 2, 0]}); + modify({a: [1, 2]}, {$mul: {'a.0': 2}}, {a: [2, 2]}); + modify({a: [1, 2]}, {$mul: {'a.1': 3}}, {a: [1, 6]}); + modify({a: [1, 2]}, {$mul: {'a.1': 10}}, {a: [1, 20]}); + modify({a: [1, 2]}, {$mul: {'a.2': 10}}, {a: [1, 2, 0]}); modify({a: {b: 2}}, {$mul: {'a.b': 1}}, {a: {b: 2}}); modify({a: {b: 2}}, {$mul: {'a.c': 10}}, {a: {b: 2, c: 0}});