From 3b6c1bc741560516d170cf86bc8e453aaca0452c Mon Sep 17 00:00:00 2001
From: Avital Oliver <avital@thewe.net>
Date: Fri, 1 Mar 2013 11:37:18 -0800
Subject: [PATCH] Glasser code review

---
 lib/warehouse.js                                      | 2 +-
 tools/admin/publish-release/server/publish-release.js | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/warehouse.js b/lib/warehouse.js
index b70558b167..ee284f1d91 100644
--- a/lib/warehouse.js
+++ b/lib/warehouse.js
@@ -124,7 +124,7 @@ var warehouse = module.exports = {
       releaseManifest = JSON.parse(Future.wrap(files.getUrl)(
         PACKAGES_URLBASE + "/releases/" + releaseVersion + ".json").wait());
     } catch (e) {
-      console.error("Can't find release " + releaseVersion);
+      console.error("Release hasn't been published to Meteor's servers: " + releaseVersion);
       process.exit(1);
     }
 
diff --git a/tools/admin/publish-release/server/publish-release.js b/tools/admin/publish-release/server/publish-release.js
index 448e1463df..e6a63d3b46 100644
--- a/tools/admin/publish-release/server/publish-release.js
+++ b/tools/admin/publish-release/server/publish-release.js
@@ -59,7 +59,7 @@ var getManifest = function(s3, release) {
 };
 
 // are there any files with this prefix?
-var notEmpty = function(s3, prefix) {
+var noneWithPrefix = function(s3, prefix) {
   var files = s3.ListObjects({
     BucketName: "com.meteor.packages",
     Prefix: prefix
@@ -74,7 +74,7 @@ var publishEngine = function(s3, release, version) {
   var destPath = ["engines", version].join("/");
 
   process.stdout.write("Engine " + version + ": ");
-  if (notEmpty(s3, destPath)) {
+  if (noneWithPrefix(s3, destPath)) {
     console.log("already published");
     return;
   } else {
@@ -110,7 +110,7 @@ var publishPackage = function(s3, release, name, version) {
   var sourceKey = ["unpublished", release, filename].join("/");
 
   process.stdout.write("Package " + name + " version " + version + ": ");
-  if (notEmpty(s3, destKey)) {
+  if (noneWithPrefix(s3, destKey)) {
     console.log("already published");
     return;
   } else {
@@ -134,7 +134,7 @@ var publishManifest = function(s3, release) {
   var sourceKey = ["unpublished", release, "manifest.json"].join("/");
 
   process.stdout.write("Release manifest " + release + ": ");
-  if (notEmpty(s3, destKey)) {
+  if (noneWithPrefix(s3, destKey)) {
     console.log("already published");
     return;
   } else {