From 3bc4c76add72c54daa0c97823df35a2ce14b1ee4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Tue, 19 Aug 2025 13:26:37 +0200 Subject: [PATCH] enable meta tag assertions in react router tests --- tools/modern-tests/react-router.test.js | 31 +++++++++---------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/tools/modern-tests/react-router.test.js b/tools/modern-tests/react-router.test.js index 8aa93f327c..e7dbadd4a1 100644 --- a/tools/modern-tests/react-router.test.js +++ b/tools/modern-tests/react-router.test.js @@ -1,15 +1,6 @@ -import { - killProcessByPort, - cleanupTempDir, - killMeteorProcess, - createMeteorApp, - runMeteorApp, - waitForMeteorOutput, waitForPlaywrightConsole -} from "./helpers"; -import { testMeteorBundler, testMeteorRspackBundler } from './test-helpers'; -import fs from 'fs-extra'; -import path from 'path'; -import { assertBodyStyles, assertMeteorReactApp } from "./assertions"; +import { waitForMeteorOutput } from "./helpers"; +import { testMeteorRspackBundler } from './test-helpers'; +import { assertBodyStyles, assertMetaTags } from "./assertions"; describe('ReactRouter App Bundling /', () => { describe('Meteor+Rspack Bundler /', testMeteorRspackBundler({ @@ -30,10 +21,10 @@ describe('ReactRouter App Bundling /', () => { await assertBodyStyles({ 'white-space': 'break-spaces', }); - // TODO assert - // await assertMetaTags({ - // 'theme-color': '#4285f4', - // }); + // Custom html rspack plugin options + await assertMetaTags({ + 'theme-color': '#4285f4', + }); }, afterRunRebuildClient: async ({ allConsoleLogs }) => { // Check for HMR output as enabled by default @@ -47,10 +38,10 @@ describe('ReactRouter App Bundling /', () => { await assertBodyStyles({ 'white-space': 'break-spaces', }); - // TODO assert - // await assertMetaTags({ - // 'theme-color': '#4285f4', - // }); + // Custom html rspack plugin options + await assertMetaTags({ + 'theme-color': '#4285f4', + }); }, afterRunProductionRebuildClient: async ({ allConsoleLogs }) => { // Check for HMR to not be enabled in production-like mode