From 4fbf7171787d962373942e8bba254b5a7041a5bd Mon Sep 17 00:00:00 2001
From: Zhenya <zhenya@meteor.com>
Date: Fri, 12 Jun 2015 15:29:36 -0700
Subject: [PATCH] provide for popup blockers when window.open returns
 undefined, throw nice error

---
 packages/oauth/oauth_browser.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/packages/oauth/oauth_browser.js b/packages/oauth/oauth_browser.js
index c9806c9ae1..54b53076a7 100644
--- a/packages/oauth/oauth_browser.js
+++ b/packages/oauth/oauth_browser.js
@@ -56,7 +56,16 @@ var openCenteredPopup = function(url, width, height) {
                   ',left=' + left + ',top=' + top + ',scrollbars=yes');
 
   var newwindow = window.open(url, 'Login', features);
+
+  if (typeof newwindow === 'undefined') {
+    // blocked by a popup blocker maybe?
+    var err = new Error("The popup was blocked by the browser");
+    err.attemptedUrl = url;
+    throw err;
+  }
+
   if (newwindow.focus)
     newwindow.focus();
+  
   return newwindow;
 };
\ No newline at end of file