From 637686986ef3c675d8aeb66176ba4e7d626c6587 Mon Sep 17 00:00:00 2001 From: David Glasser Date: Fri, 31 May 2013 13:02:20 -0700 Subject: [PATCH] oauth1: Don't try to render results after sending a redirect. This now causes an error, but was always wrong. --- packages/oauth1/oauth1_server.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/oauth1/oauth1_server.js b/packages/oauth1/oauth1_server.js index 6339573302..565610d911 100644 --- a/packages/oauth1/oauth1_server.js +++ b/packages/oauth1/oauth1_server.js @@ -26,7 +26,6 @@ Oauth1._handleRequest = function (service, query, res) { var redirectUrl = urls.authenticate + '?oauth_token=' + oauthBinding.requestToken; res.writeHead(302, {'Location': redirectUrl}); res.end(); - } else { // step 2, redirected from provider login - complete the login // process: if the user authorized permissions, get an access @@ -56,9 +55,9 @@ Oauth1._handleRequest = function (service, query, res) { options: oauthResult.options }; } - } - // Either close the window, redirect, or render nothing - // if all else fails - Oauth._renderOauthResults(res, query); + // Either close the window, redirect, or render nothing + // if all else fails + Oauth._renderOauthResults(res, query); + } };