From b91b6069ade9f96c5a7964a7f162ad6bef6f2b92 Mon Sep 17 00:00:00 2001 From: dolgarev Date: Sat, 6 Jun 2015 22:20:21 +0300 Subject: [PATCH 1/2] added check of params for template's methods events and helpers --- packages/blaze/template.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/blaze/template.js b/packages/blaze/template.js index b6be72771d..2d4f3eb635 100644 --- a/packages/blaze/template.js +++ b/packages/blaze/template.js @@ -437,6 +437,10 @@ Blaze.TemplateInstance.prototype.subscriptionsReady = function () { * @param {Object} helpers Dictionary of helper functions by name. */ Template.prototype.helpers = function (dict) { + if (Object.prototype.toString.call(dict) !== "[object Object]") { + throw new Error('Dictionary of helper must be an object'); + } + for (var k in dict) this.__helpers.set(k, dict[k]); }; @@ -466,6 +470,10 @@ Template._withTemplateInstanceFunc = function (templateInstanceFunc, func) { * @param {EventMap} eventMap Event handlers to associate with this template. */ Template.prototype.events = function (eventMap) { + if (Object.prototype.toString.call(eventMap) !== "[object Object]") { + throw new Error('Event Map must be an object'); + } + var template = this; var eventMap2 = {}; for (var k in eventMap) { From 912c07cc1c5631d8dc5e6920ec76b38514719a0e Mon Sep 17 00:00:00 2001 From: dolgarev Date: Sat, 6 Jun 2015 22:24:38 +0300 Subject: [PATCH 2/2] fixed error messages --- packages/blaze/template.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/blaze/template.js b/packages/blaze/template.js index 2d4f3eb635..cea68b4ec2 100644 --- a/packages/blaze/template.js +++ b/packages/blaze/template.js @@ -438,7 +438,7 @@ Blaze.TemplateInstance.prototype.subscriptionsReady = function () { */ Template.prototype.helpers = function (dict) { if (Object.prototype.toString.call(dict) !== "[object Object]") { - throw new Error('Dictionary of helper must be an object'); + throw new Error('Template: Dictionary of helper must be an object'); } for (var k in dict) @@ -471,7 +471,7 @@ Template._withTemplateInstanceFunc = function (templateInstanceFunc, func) { */ Template.prototype.events = function (eventMap) { if (Object.prototype.toString.call(eventMap) !== "[object Object]") { - throw new Error('Event Map must be an object'); + throw new Error('Template: Event Map must be an object'); } var template = this;