From 6fac3d2ec720ca4cbc7f88a3bfe0761230029150 Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Sat, 7 May 2016 13:03:39 -0400 Subject: [PATCH] Comment about http 'finish' and (unused) 'prefinish' events. --- packages/webapp/webapp_server.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/webapp/webapp_server.js b/packages/webapp/webapp_server.js index 4da8eb4b24..130258d876 100644 --- a/packages/webapp/webapp_server.js +++ b/packages/webapp/webapp_server.js @@ -218,8 +218,10 @@ WebApp._timeoutAdjustmentRequestCallback = function (req, res) { // Insert our new finish listener to run BEFORE the existing one which removes // the response from the socket. var finishListeners = res.listeners('finish'); - // XXX Apparently in Node 0.12 this event is now called 'prefinish'. + // XXX Apparently in Node 0.12 this event was called 'prefinish'. // https://github.com/joyent/node/commit/7c9b6070 + // But it has switched back to 'finish' in Node v4: + // https://github.com/nodejs/node/pull/1411 res.removeAllListeners('finish'); res.on('finish', function () { res.setTimeout(SHORT_SOCKET_TIMEOUT);