From 7ca88892e45c2e27acddf91ae06230827c278e42 Mon Sep 17 00:00:00 2001 From: David Greenspan Date: Wed, 4 Mar 2015 10:10:42 -0800 Subject: [PATCH] Add note to a logic_test --- packages/logic-solver/logic_tests.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/logic-solver/logic_tests.js b/packages/logic-solver/logic_tests.js index d320bc68aa..0354c70de2 100644 --- a/packages/logic-solver/logic_tests.js +++ b/packages/logic-solver/logic_tests.js @@ -1507,7 +1507,9 @@ Tinytest.add("logic-solver - toy packages", function (test) { // e.g. implies("bar@1.2.4", "foo") solver.require(Logic.implies(packageVersion, package2)); // Now ban all incompatible versions of package2 if - // we select this packageVersion + // we select this packageVersion. + // NOTE: This is not the best way to express constraints. It's + // not what we do in the real package constraint solver. _.each(allPackageVersions[package2], function (v) { if (! _.contains(compatibleVersions, v)) { solver.require(Logic.implies(packageVersion,