From 88004d46490cef200d2c2302ee2aa44e67335e47 Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Mon, 17 Jun 2019 13:17:53 -0400 Subject: [PATCH] Add a basic regression test of issue #10563. --- tools/tests/apps/modules/package-lock.json | 5 +++++ tools/tests/apps/modules/package.json | 1 + tools/tests/apps/modules/tests.js | 12 ++++++++++++ 3 files changed, 18 insertions(+) diff --git a/tools/tests/apps/modules/package-lock.json b/tools/tests/apps/modules/package-lock.json index 1e2ac9d470..8bacd1665f 100644 --- a/tools/tests/apps/modules/package-lock.json +++ b/tools/tests/apps/modules/package-lock.json @@ -1350,6 +1350,11 @@ "resolved": "https://registry.npmjs.org/pend/-/pend-1.2.0.tgz", "integrity": "sha1-elfrVQpng/kRUzH89GY9XI4AelA=" }, + "pify": { + "version": "4.0.1", + "resolved": "https://registry.npmjs.org/pify/-/pify-4.0.1.tgz", + "integrity": "sha512-uB80kBFb/tfd68bVleG9T5GGsGPjJrLAUpR5PZIrhBnIaRTQRjqdJSsIKkOP6OAIFbj7GOrcudc5pNjZ+geV2g==" + }, "process-nextick-args": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/process-nextick-args/-/process-nextick-args-2.0.0.tgz", diff --git a/tools/tests/apps/modules/package.json b/tools/tests/apps/modules/package.json index 294dd791b1..71e483a11c 100644 --- a/tools/tests/apps/modules/package.json +++ b/tools/tests/apps/modules/package.json @@ -22,6 +22,7 @@ "moment": "^2.22.2", "mssql": "^3.1.1", "mysql": "^2.15.0", + "pify": "^4.0.1", "puppeteer": "^1.6.2", "regenerator-runtime": "^0.11.1", "stripe": "^4.4.0", diff --git a/tools/tests/apps/modules/tests.js b/tools/tests/apps/modules/tests.js index 3dfe131957..7d9399f12f 100644 --- a/tools/tests/apps/modules/tests.js +++ b/tools/tests/apps/modules/tests.js @@ -682,3 +682,15 @@ describe("issue #10409", () => { assert.strictEqual(typeof action, "function"); }); }); + +describe("issue #10563", () => { + it("should be able to import pify@4.0.1 in legacy browsers", () => { + const pify = require("pify"); + assert.strictEqual(typeof pify, "function"); + const code = Function.prototype.toString.call(pify); + assert.strictEqual( + /\bconst\b/.test(code), + Meteor.isModern, + ); + }); +});