From 8c89cfa175bf3cd075dc4eeec858f3aab8f8cb18 Mon Sep 17 00:00:00 2001 From: David Glasser Date: Fri, 29 May 2015 17:52:41 -0700 Subject: [PATCH] Don't always set noLineNumbers @benjamn convinced me that line numbers are still nice, and especially so with the changes that let them come from original source files. And due to https://github.com/meteor/meteor/commit/b556e62262f365f01a023e24fb7517eb52d5a20f#commitcomment-11437623 noLineNumbers currently totally disables source maps, which is silly. --- tools/compiler-plugin.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/compiler-plugin.js b/tools/compiler-plugin.js index be771f542f..f20ebdebe0 100644 --- a/tools/compiler-plugin.js +++ b/tools/compiler-plugin.js @@ -491,12 +491,6 @@ _.extend(PackageSourceBatch.prototype, { ".js"), name: self.unibuild.pkg.name || null, declaredExports: _.pluck(self.unibuild.declaredExports, 'name'), - // It's not clear how much people end up looking at these generated files, - // so for now let's not spend lots of time writing tons of spaces every - // time we bundle the app. - // XXX BBP theory: 'meteor build' writes line numbers and 'meteor run' - // does not??? - noLineNumbers: true, imports: imports, // XXX report an error if there is a package called global-imports importStubServePath: isApp && '/packages/global-imports.js',