From f7a48a485fac2ce51542c8d03a7486b473a52ee3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 6 Mar 2024 06:49:48 +0100 Subject: [PATCH 1/6] spread debug mode to the client --- packages/meteor/debug.js | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/meteor/debug.js b/packages/meteor/debug.js index 8bb4fdb0a5..707bd26915 100644 --- a/packages/meteor/debug.js +++ b/packages/meteor/debug.js @@ -1,3 +1,19 @@ +if (Meteor.isServer) { + if (typeof __meteor_runtime_config__ === 'object') { + __meteor_runtime_config__.debug = + !!process.env.NODE_INSPECTOR_IPC || + !!process.env.VSCODE_INSPECTOR_OPTIONS || + process.execArgv.some(_arg => + /^--(inspect|debug)(-brk)?(=\d+)?$/i.test(_arg), + ); + } +} + +Meteor.isDebug = Meteor.isClient + ? typeof window === 'object' && !!window.__meteor_runtime_config__.debug + : typeof __meteor_runtime_config__ === 'object' && + !!__meteor_runtime_config__.debug; + var suppress = 0; // replacement for console.log. This is a temporary API. We should @@ -61,4 +77,3 @@ Meteor._suppress_log = function (count) { Meteor._suppressed_log_expected = function () { return suppress !== 0; }; - From f4a8596816e1c71f535ea22e953049beb56e1872 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 6 Mar 2024 06:50:07 +0100 Subject: [PATCH 2/6] show the warning on method stub only in debug mode --- packages/ddp-client/client/queueStubsHelpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ddp-client/client/queueStubsHelpers.js b/packages/ddp-client/client/queueStubsHelpers.js index 275756047a..002171dd18 100644 --- a/packages/ddp-client/client/queueStubsHelpers.js +++ b/packages/ddp-client/client/queueStubsHelpers.js @@ -107,7 +107,7 @@ export const loadAsyncStubHelpers = () => { }); Meteor._setImmediate(() => { - if (!finished) { + if (!finished && Meteor.isDebug) { console.warn( `Method stub (${name}) took too long and could cause unexpected problems. Learn more at https://github.com/zodern/fix-async-stubs/#limitations` ); From 45ed85d8424c6f86849f2a94ab724bfb311829b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 6 Mar 2024 06:59:19 +0100 Subject: [PATCH 3/6] dont use arrow function --- packages/meteor/debug.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/meteor/debug.js b/packages/meteor/debug.js index 707bd26915..bf8837a4e8 100644 --- a/packages/meteor/debug.js +++ b/packages/meteor/debug.js @@ -3,9 +3,9 @@ if (Meteor.isServer) { __meteor_runtime_config__.debug = !!process.env.NODE_INSPECTOR_IPC || !!process.env.VSCODE_INSPECTOR_OPTIONS || - process.execArgv.some(_arg => - /^--(inspect|debug)(-brk)?(=\d+)?$/i.test(_arg), - ); + process.execArgv.some(function(_arg) { + return /^--(inspect|debug)(-brk)?(=\d+)?$/i.test(_arg); + }); } } From f2976aabcb6e26c78bdb03b538c0b3b9d906bdf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 6 Mar 2024 07:04:43 +0100 Subject: [PATCH 4/6] re-run checks From 7c494c94c5f3de42c3ef4cbefcd1e781dc67ad69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 6 Mar 2024 17:08:53 +0100 Subject: [PATCH 5/6] dont skip important warning for showing on normal execution mode --- packages/ddp-client/client/queueStubsHelpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ddp-client/client/queueStubsHelpers.js b/packages/ddp-client/client/queueStubsHelpers.js index 002171dd18..275756047a 100644 --- a/packages/ddp-client/client/queueStubsHelpers.js +++ b/packages/ddp-client/client/queueStubsHelpers.js @@ -107,7 +107,7 @@ export const loadAsyncStubHelpers = () => { }); Meteor._setImmediate(() => { - if (!finished && Meteor.isDebug) { + if (!finished) { console.warn( `Method stub (${name}) took too long and could cause unexpected problems. Learn more at https://github.com/zodern/fix-async-stubs/#limitations` ); From 53d3b8ea2d5565b1bd78c900468dbde35cc7d632 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Tue, 12 Mar 2024 15:15:01 +0100 Subject: [PATCH 6/6] add debug mode change to the changelog --- docs/generators/changelog/versions/3.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/generators/changelog/versions/3.0.md b/docs/generators/changelog/versions/3.0.md index bf6e90d74a..5eb9af3514 100644 --- a/docs/generators/changelog/versions/3.0.md +++ b/docs/generators/changelog/versions/3.0.md @@ -667,6 +667,9 @@ - `Meteor.callAsync()` +- `meteor`: + - Added `Meteor.isDebug` to execute code in debug builds, activated with the --inspect mode. + - `minifier-css`: (2.9+) - `CssTools.minifyCssAsync()`