From 8ef032638044de34d88571e554d9cfba19a330c4 Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Tue, 2 Jul 2019 13:11:11 -0400 Subject: [PATCH] Keep using module.useNode() instead of bundling server node_modules. This partially reverts commit 4dfc74197a98a31e8f763b44681347a3585d87a3. Some server packages, especially those that rely on __dirname or __filename (e.g. puppeteer), simply cannot be included in the server bundle, and must be evaluated natively by Node. As long as we have a Module.prototype._compile hook to process natively evaluated modules with Reify, module.useNode() can still benefit from ESM import/export syntax. --- tools/isobuild/import-scanner.js | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/tools/isobuild/import-scanner.js b/tools/isobuild/import-scanner.js index 5e685f91a9..f0252dd05d 100644 --- a/tools/isobuild/import-scanner.js +++ b/tools/isobuild/import-scanner.js @@ -1222,17 +1222,6 @@ export default class ImportScanner { return false; } - if ( - absModuleId.endsWith(".js") || - absModuleId.endsWith(".mjs") - ) { - return false; - } - - if (absModuleId.endsWith(".node")) { - return true; - } - const parts = absModuleId.split("/"); let start = 0;