From a016e83754da6987f4952b41f93203359c04625e Mon Sep 17 00:00:00 2001 From: David Glasser Date: Tue, 25 Sep 2012 18:26:06 -0700 Subject: [PATCH] Let exceptions from stream message callbacks percolate upwards. We used to be unable to do this because of a SockJS bug, but the SockJS folks read our XXX comment and fixed the bug! https://github.com/sockjs/sockjs-client/issues/61 --- packages/stream/stream_client.js | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/stream/stream_client.js b/packages/stream/stream_client.js index 577b2701dd..0f70866b75 100644 --- a/packages/stream/stream_client.js +++ b/packages/stream/stream_client.js @@ -327,16 +327,7 @@ _.extend(Meteor._Stream.prototype, { self._connected(data.data); else if (self.current_status.connected) _.each(self.event_callbacks.message, function (callback) { - try { - callback(data.data); - } catch (e) { - // XXX sockjs catches and silently ignores any exceptions - // that we raise here. not sure what we should do, but for - // now, just print the exception so you are at least aware - // that something went wrong. - // XXX improve error message - Meteor._debug("Exception while processing message", e.stack); - } + callback(data.data); }); self._heartbeat_received();