From a03ccfc100db913eef10fc11c1177236d4e9a260 Mon Sep 17 00:00:00 2001 From: Daniel C Date: Wed, 28 Jun 2017 16:57:30 +0300 Subject: [PATCH] Adjusted proxy methods explanation comment --- packages/localstorage/localstorage.js | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/localstorage/localstorage.js b/packages/localstorage/localstorage.js index 70907463d7..4933ad6a1f 100644 --- a/packages/localstorage/localstorage.js +++ b/packages/localstorage/localstorage.js @@ -24,17 +24,11 @@ if (key === retrieved) { if (Meteor.isServer) { Meteor._localStorage = storage; } else { - // IE11 doesn't handle properly attempts to change methods of the - // window.localStorage, attempts to do so will result in the complete - // break of the localStorage system for the domain in which it is - // done - until the user clean the browser/domain cache. - // - // Therefore, in the web, we don't set Meteor._localStorage to be a - // reference to window.localStorage . Instead, we set proxy methods. - // - // This will allow package developers that will find a need to change - // the behavior of Meteor._localStorage methods to do so without breaking - // the localStorage system on IE11. (e.g. meteorhacks:fast-render) + // Some browsers (e.g. IE11) don't properly handle attempts to change + // window.localStorage methods. By using proxy methods to expose + // window.localStorage functionality, developers can change + // the behavior of Meteor._localStorage methods without breaking + // window.localStorage. Meteor._localStorage = { getItem: function (key) {