From a80185846a1886eeb891734620419b3fbba355cb Mon Sep 17 00:00:00 2001 From: Avital Oliver Date: Wed, 26 Aug 2015 12:35:19 -0700 Subject: [PATCH] Revert "Glasser code review comments" This reverts commit a4a92b3f8f046610fc29ab6365b4eb58dd76c772. Going to squash and re-commit --- packages/minimongo/call_in_observe_test.js | 2 +- packages/minimongo/minimongo.js | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/minimongo/call_in_observe_test.js b/packages/minimongo/call_in_observe_test.js index fb0ac4a1ec..9b3f172c08 100644 --- a/packages/minimongo/call_in_observe_test.js +++ b/packages/minimongo/call_in_observe_test.js @@ -21,7 +21,7 @@ if (Meteor.isClient) { LocalCollection.find().observe({ added: function () { Meteor.call("isRunningOnServer", function (err, res) { - test.isFalse(err); + test.equal(err, undefined); test.equal(res, true); done(); }); diff --git a/packages/minimongo/minimongo.js b/packages/minimongo/minimongo.js index bc5afdbb70..a1ce954a0c 100644 --- a/packages/minimongo/minimongo.js +++ b/packages/minimongo/minimongo.js @@ -372,10 +372,6 @@ _.extend(LocalCollection.Cursor.prototype, { // be able to call `Meteor.call` within these wrapped // functions and actually end up calling a server method (as // opposed to just a client stub) - // - // XXX this shouldn't be necessary once #2315 is fixed (that - // is -- if we no longer run observe callbacks synchronously - // on Minimongo mutations). var wrapNotInMethodStub = function (f) { // It is strange that we refer to the `ddp` package directly // here. This pattern appears elsewhere in the code, but