From aa8403ae2e1eac6b60ed90020606ffabedaeaf5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Mon, 9 Mar 2026 14:13:43 +0100 Subject: [PATCH] rename `tools/modern-tests` to `tools/e2e-tests` and update references --- .github/skills/testing/SKILL.md | 2 +- .github/workflows/e2e-tests.yml | 4 ++-- DEVELOPMENT.md | 4 ++-- package.json | 4 ++-- tools/unit-tests/jest.config.js | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/skills/testing/SKILL.md b/.github/skills/testing/SKILL.md index 160ba85c97..3f829e665e 100644 --- a/.github/skills/testing/SKILL.md +++ b/.github/skills/testing/SKILL.md @@ -31,7 +31,7 @@ npm run test:modern # Run all E2E tests npm run test:modern -- -t="React" # Run specific test ``` -## Modern E2E Tests (`tools/modern-tests/`) +## Modern E2E Tests (`tools/e2e-tests/`) Jest + Playwright suite for verifying modern bundler integrations (rspack). Tests cover framework skeletons and build scenarios. diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 7bd60570ae..ed3d711da6 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -4,7 +4,7 @@ on: pull_request: paths: - 'meteor' - - 'tools/modern-tests/**' + - 'tools/e2e-tests/**' - 'packages/rspack/**' - 'packages/tools-core/**' - 'packages/babel-compiler/**' @@ -52,7 +52,7 @@ jobs: path: | ~/.npm node_modules - tools/modern-tests/node_modules + tools/e2e-tests/node_modules packages/**/.npm .meteor dev_bundle diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 58eda23621..d14f9c746b 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -148,7 +148,7 @@ Place test files next to the module they test using the `*.test.js` naming conve ### E2E tests (Jest + Playwright) -End-to-end tests in `tools/modern-tests/` validate that Meteor skeletons and bundler integrations work correctly. They create real Meteor apps, start dev servers, and assert behavior in a headless Chromium browser. +End-to-end tests in `tools/e2e-tests/` validate that Meteor skeletons and bundler integrations work correctly. They create real Meteor apps, start dev servers, and assert behavior in a headless Chromium browser. ```sh # Install dependencies (first time) @@ -161,7 +161,7 @@ npm run test:e2e npm run test:e2e -- -t="React" ``` -Each test has a corresponding app fixture in `tools/modern-tests/apps/`. See that directory for examples when adding new E2E tests. +Each test has a corresponding app fixture in `tools/e2e-tests/apps/`. See that directory for examples when adding new E2E tests. ### Self-tests (Meteor tool) diff --git a/package.json b/package.json index 9c096fcd0a..99d103e75f 100644 --- a/package.json +++ b/package.json @@ -38,8 +38,8 @@ "install:unit": "cd tools/unit-tests && npm install", "test:unit": "cd tools/unit-tests && npm test", "test:idle-bot": "node --test .github/scripts/__tests__/inactive-issues.test.js", - "install:e2e": "cd tools/modern-tests && npm install && npx playwright install --with-deps chromium chromium-headless-shell", - "test:e2e": "cd tools/modern-tests && npm test -- " + "install:e2e": "cd tools/e2e-tests && npm install && npx playwright install --with-deps chromium chromium-headless-shell", + "test:e2e": "cd tools/e2e-tests && npm test -- " }, "jshintConfig": { "esversion": 11 diff --git a/tools/unit-tests/jest.config.js b/tools/unit-tests/jest.config.js index a21cc6c896..f78071ebc9 100644 --- a/tools/unit-tests/jest.config.js +++ b/tools/unit-tests/jest.config.js @@ -10,13 +10,13 @@ module.exports = { ], testPathIgnorePatterns: [ "/node_modules/", - "/tools/modern-tests/", + "/tools/e2e-tests/", "/tools/tests/", "/packages/", "/.github/", ], modulePathIgnorePatterns: [ - "/tools/modern-tests/", + "/tools/e2e-tests/", "/tools/tests/", "/tools/static-assets/", "/npm-packages/",