From ada34ef3ce3a4600596da96deaa37c8b322b2537 Mon Sep 17 00:00:00 2001 From: dr-dimitru Date: Tue, 17 Jan 2017 13:48:32 +0300 Subject: [PATCH] Requested changes + JavaScript Style Guide rules - Changes according to PR request - Apply rule [#16.1](https://github.com/meteor/javascript#16.1) to if/else blocks --- packages/mongo/observe_changes_tests.js | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/packages/mongo/observe_changes_tests.js b/packages/mongo/observe_changes_tests.js index 8cf60f9b1b..5700da35d2 100644 --- a/packages/mongo/observe_changes_tests.js +++ b/packages/mongo/observe_changes_tests.js @@ -1,17 +1,20 @@ var makeCollection = function () { - if (Meteor.isServer) + if (Meteor.isServer) { return new Mongo.Collection(Random.id()); - else + } else { return new Mongo.Collection(null); + } }; -_.each ([{added:'added', forceOrdered: true}, - {added:'added', forceOrdered: false}, +_.each ([{added: 'added', forceOrdered: true}, + {added: 'added', forceOrdered: false}, {added: 'addedBefore', forceOrdered: false}], function (options) { - var added = options.added; - var forceOrdered = options.forceOrdered; + var added = options.added; + var forceOrdered = options.forceOrdered; - Tinytest.addAsync("observeChanges - single id - basics " + added + (forceOrdered ? " force ordered" : ""), function (test, onComplete) { + Tinytest.addAsync("observeChanges - single id - basics " + added + + (forceOrdered ? " force ordered" : ""), + function (test, onComplete) { var c = makeCollection(); var counter = 0; var callbacks = [added, "changed", "removed"]; @@ -25,11 +28,12 @@ _.each ([{added:'added', forceOrdered: true}, var fooid = c.insert({noodles: "good", bacon: "bad", apples: "ok"}); var handle = c.find(fooid).observeChanges(logger); - if (added === 'added') - logger.expectResult(added, [fooid, {noodles: "good", bacon: "bad",apples: "ok"}]); - else + if (added === 'added') { + logger.expectResult(added, [fooid, {noodles: "good", bacon: "bad", apples: "ok"}]); + } else { logger.expectResult(added, [fooid, {noodles: "good", bacon: "bad", apples: "ok"}, null]); + } c.update(fooid, {noodles: "alright", potatoes: "tasty", apples: "ok"}); logger.expectResult("changed", [fooid, {noodles: "alright", potatoes: "tasty", bacon: undefined}]);