From afff9dd46007a7e0efe97dbb8d3a997a8fd25478 Mon Sep 17 00:00:00 2001 From: Dominik Ferber Date: Wed, 9 May 2018 23:42:00 +0200 Subject: [PATCH] refactor: require at least node@6 (drop node@4 support) Please upgrade node in case you are affected by this. node@6 is the current LTS version (https://github.com/nodejs/Release#release-schedule). BREAKING CHANGE: Dropped support of outdated node versions. This package requires at least node@6 now. --- .travis.yml | 1 - lib/rules/template-names.js | 4 +++- lib/util/values.js | 1 + package.json | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 lib/util/values.js diff --git a/.travis.yml b/.travis.yml index e289e60563..e9b7f04f5e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,7 +14,6 @@ notifications: node_js: - 8 - 6 - - 4 - 10 before_install: - npm i -g npm@^6.0.0 diff --git a/lib/rules/template-names.js b/lib/rules/template-names.js index 765dca9466..2983eebc69 100644 --- a/lib/rules/template-names.js +++ b/lib/rules/template-names.js @@ -5,6 +5,8 @@ * See LICENSE file in root directory for full license. */ +const values = require('../util/values'); + const templateProps = new Set([ 'onCreated', 'onRendered', @@ -41,7 +43,7 @@ const getErrorMessage = expected => module.exports = { meta: { - schema: [{ enum: Object.values(NAMING_CONVENTIONS) }], + schema: [{ enum: values(NAMING_CONVENTIONS) }], }, create: context => ({ MemberExpression: node => { diff --git a/lib/util/values.js b/lib/util/values.js new file mode 100644 index 0000000000..71ac7412b7 --- /dev/null +++ b/lib/util/values.js @@ -0,0 +1 @@ +module.exports = obj => Object.keys(obj).map(key => obj[key]); diff --git a/package.json b/package.json index 9f5f8e2e5d..447a68a8bf 100644 --- a/package.json +++ b/package.json @@ -60,7 +60,7 @@ "eslint": ">= 3.7.0 < 5" }, "engines": { - "node": ">=4" + "node": ">=6" }, "keywords": [ "eslint",