From b1c3f22ff4604569a5c13aef130a8bf55f1bfacc Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Wed, 6 Apr 2016 11:04:09 -0400 Subject: [PATCH] Make quiet symlink loop checking the default. Fixes #6665. --- tools/isobuild/package-source.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/isobuild/package-source.js b/tools/isobuild/package-source.js index 3adbc4dcaa..f8b6ba1e45 100644 --- a/tools/isobuild/package-source.js +++ b/tools/isobuild/package-source.js @@ -201,7 +201,7 @@ class SymlinkLoopChecker { this._realpathCache = {}; } - check(relDir, quietly) { + check(relDir, quietly = true) { const absPath = files.pathJoin(this.sourceRoot, relDir); try { @@ -213,7 +213,7 @@ class SymlinkLoopChecker { // else leave realPath undefined } - if (realPath === undefined || _.has(this._seenPaths, realPath)) { + if (! realPath || _.has(this._seenPaths, realPath)) { if (! quietly) { buildmessage.error("Symlink cycle detected at " + relDir); }