From b5acef6def1bc12a950e387a218db5d4fc83d3be Mon Sep 17 00:00:00 2001 From: Tom Coleman Date: Fri, 6 May 2016 10:00:57 -0700 Subject: [PATCH] Stack parsing test was failing due to longjohn --- tools/tests/parse-stack-test.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/tests/parse-stack-test.js b/tools/tests/parse-stack-test.js index 0c804e7585..f92475b8b1 100644 --- a/tools/tests/parse-stack-test.js +++ b/tools/tests/parse-stack-test.js @@ -12,8 +12,11 @@ selftest.define("parse-stack - parse stack traces without fibers", () => { const firstFilePath = files.convertToStandardPath(parsedStack[0].file); selftest.expectEqual(_.last(firstFilePath.split("/")), "parse-stack-test.js"); - const lastFilePath = files.convertToStandardPath(_.last(parsedStack).file); - selftest.expectEqual(_.last(lastFilePath.split("/")), "main.js"); + // This is no longer true as longjohn adds a bunch of pre-app frames to the + // call stack. However it doesn't seem we actually rely on this behavior + // anywhere + // const lastFilePath = files.convertToStandardPath(_.last(parsedStack).file); + // selftest.expectEqual(_.last(lastFilePath.split("/")), "main.js"); markBottom(() => { const markedErr = new Error();