From b8159f852fef17406d2e6d7c2d685ba10dc579e1 Mon Sep 17 00:00:00 2001 From: David Greenspan Date: Wed, 18 Sep 2013 15:53:22 -0700 Subject: [PATCH] make "rendered" wait to fire until parented otherwise "findAll" won't work from "rendered" --- packages/ui/base.js | 6 ++++++ packages/ui/render.js | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/ui/base.js b/packages/ui/base.js index 24779cc4d2..0fda88a403 100644 --- a/packages/ui/base.js +++ b/packages/ui/base.js @@ -1210,6 +1210,12 @@ UI.Component.parented = function () { self.dom.on(esh.events, esh.selector, esh.handler); }); } + + // XXX think about this callback's timing + if (self.rendered) { + updateTemplateInstance(self); + self.rendered.call(self.templateInstance); + } }; // XXX diff --git a/packages/ui/render.js b/packages/ui/render.js index cc1c0f9491..2436d50a15 100644 --- a/packages/ui/render.js +++ b/packages/ui/render.js @@ -82,12 +82,6 @@ UI.render = function (kind, props, parentComp) { }); } - // XXX think about this callback's semantics - if (comp.rendered) { - updateTemplateInstance(comp); - comp.rendered.call(comp.templateInstance); - } - return comp; };