From ba0403c19342ab6da88a0aa74c2095b0ceb962b5 Mon Sep 17 00:00:00 2001 From: Christian Klaussner Date: Tue, 12 Sep 2017 12:46:16 +0200 Subject: [PATCH] Fix host IP fallback for `webapp` server The `localIp` constant was never used, so the HTTP server was started with an `undefined` host instead of "0.0.0.0" if `process.env.BIND_IP` was `undefined`. --- packages/webapp/webapp_server.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/webapp/webapp_server.js b/packages/webapp/webapp_server.js index ebd5728278..d59d91d2e9 100644 --- a/packages/webapp/webapp_server.js +++ b/packages/webapp/webapp_server.js @@ -883,8 +883,6 @@ function runWebAppServer() { }; let localPort = process.env.PORT || 0; - const host = process.env.BIND_IP; - const localIp = host || "0.0.0.0"; const unixSocketPath = process.env.UNIX_SOCKET_PATH; if (unixSocketPath) { @@ -899,7 +897,10 @@ function runWebAppServer() { startHttpServer({ path: localPort }); } else if (typeof localPort === "number") { // Start the HTTP server using TCP. - startHttpServer({ port: localPort, host: host }); + startHttpServer({ + port: localPort, + host: process.env.BIND_IP || "0.0.0.0" + }); } else { throw new Error("Invalid PORT specified"); }