From c71e495e109e28b8b174728050780a49889221eb Mon Sep 17 00:00:00 2001 From: David Greenspan Date: Thu, 15 Jan 2015 22:15:06 -0500 Subject: [PATCH] Only test constraint-solver and PVP on server MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit You can still include them on the client, but they don’t work in Safari 4 and IE 8 because semver.js uses ES 5 methods including String#trim, Array#map/filter/forEach, and possibly others. This should fix any unit test failures in these packages. --- packages/constraint-solver/package.js | 4 ++-- packages/package-version-parser/package.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/constraint-solver/package.js b/packages/constraint-solver/package.js index 5996c68e95..236b2bcd52 100644 --- a/packages/constraint-solver/package.js +++ b/packages/constraint-solver/package.js @@ -25,8 +25,8 @@ Package.onTest(function (api) { // data for big benchmarky tests api.addFiles('test-data.js', ['server']); - api.addFiles('datatypes-tests.js', ['client', 'server']); - api.addFiles('catalog-cache-tests.js', ['client', 'server']); + api.addFiles('datatypes-tests.js', ['server']); + api.addFiles('catalog-cache-tests.js', ['server']); api.addFiles('constraint-solver-tests.js', ['server']); api.addFiles('benchmark-tests.js', ['server']); api.addFiles('resolver-tests.js', ['server']); diff --git a/packages/package-version-parser/package.js b/packages/package-version-parser/package.js index 968933c1c8..a535adbe1a 100644 --- a/packages/package-version-parser/package.js +++ b/packages/package-version-parser/package.js @@ -13,5 +13,5 @@ Package.onUse(function (api) { Package.onTest(function (api) { api.use('package-version-parser'); api.use(['tinytest']); - api.addFiles('package-version-parser-tests.js'); + api.addFiles('package-version-parser-tests.js', 'server'); });