From ca609e5918ccefbed5eeea7c431e3ffded4f9d87 Mon Sep 17 00:00:00 2001 From: Mike Bannister Date: Sun, 29 Jul 2012 20:39:35 -0400 Subject: [PATCH] added some comments --- packages/accounts-oauth1-helper/oauth1_server.js | 5 +++++ packages/accounts-twitter/twitter_server.js | 1 + 2 files changed, 6 insertions(+) diff --git a/packages/accounts-oauth1-helper/oauth1_server.js b/packages/accounts-oauth1-helper/oauth1_server.js index cced70c2ce..171d94a7d3 100644 --- a/packages/accounts-oauth1-helper/oauth1_server.js +++ b/packages/accounts-oauth1-helper/oauth1_server.js @@ -82,6 +82,8 @@ var querystring = __meteor_bootstrap__.require("querystring"); var config = Meteor.accounts[serviceName]; var oauth = new OAuth(config); + // If we get here with a callback url we need a request token to + // start the logic process if (req.query.callbackUrl) { // Get a request token to start auth process @@ -91,6 +93,9 @@ var querystring = __meteor_bootstrap__.require("querystring"); res.writeHead(302, {'Location': redirectUrl}); res.end(); + // If we get here without a callback url we've just + // returned from authentication via the oauth provider + } else { // XXX does checking for the verifier really make sense? diff --git a/packages/accounts-twitter/twitter_server.js b/packages/accounts-twitter/twitter_server.js index 6dcae80017..63b626747d 100644 --- a/packages/accounts-twitter/twitter_server.js +++ b/packages/accounts-twitter/twitter_server.js @@ -12,6 +12,7 @@ options: { // XXX Figure out what to do here email: identity.screen_name + '@OAUTH1_TWITTER', + // XXX Do we want to keep the accessTokenSecret also? services: {twitter: {id: identity.id, accessToken: oauth.accessToken}} }, extra: {name: identity.name}