From cce9d36dfaa3b50a894db4ed267a8ae2e5ba87a0 Mon Sep 17 00:00:00 2001 From: David Glasser Date: Thu, 12 Dec 2013 15:55:06 -0800 Subject: [PATCH] Add some XXX comments about when we should re-poll --- packages/mongo-livedata/oplog_observe_driver.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/mongo-livedata/oplog_observe_driver.js b/packages/mongo-livedata/oplog_observe_driver.js index ac2094ba75..dbd44c310b 100644 --- a/packages/mongo-livedata/oplog_observe_driver.js +++ b/packages/mongo-livedata/oplog_observe_driver.js @@ -294,6 +294,15 @@ _.extend(OplogObserveDriver.prototype, { // In various circumstances, we may just want to stop processing the oplog and // re-run the initial query, just as if we were a PollingObserveDriver. + // + // XXX We should call this when we detect that we've been in FETCHING for "too + // long". + // + // XXX We should call this when we detect Mongo failover (since that might + // mean that some of the oplog entries we have processed have been rolled + // back). The Node Mongo driver is in the middle of a bunch of huge + // refactorings, including the way that it notifies you when primary + // changes. Will put off implementing this until driver 1.4 is out. _pollQuery: function () { var self = this;