From b4d96d57957d0f990fd5e9752f0428235a2c102c Mon Sep 17 00:00:00 2001 From: "P. Mark Anderson" Date: Wed, 24 Apr 2013 09:44:38 -0700 Subject: [PATCH 1/2] Added user agent to account-github's getIdentity() function. This is untested. See https://github.com/meteor/meteor/issues/981 --- packages/accounts-github/github_server.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/accounts-github/github_server.js b/packages/accounts-github/github_server.js index 36f9ef4817..6eb6987405 100644 --- a/packages/accounts-github/github_server.js +++ b/packages/accounts-github/github_server.js @@ -43,8 +43,10 @@ var getAccessToken = function (query) { var getIdentity = function (accessToken) { var result = Meteor.http.get( - "https://api.github.com/user", - {params: {access_token: accessToken}}); + "https://api.github.com/user", { + headers: {"User-Agent": "Meteor/1.0"}, + params: {access_token: accessToken} + }); if (result.error) { throw new Error("Failed to fetch identity from GitHub. " + "HTTP Error " + result.statusCode + ": " + result.content); From e43c94ee2e993c40721956c481d6fcc3485c3093 Mon Sep 17 00:00:00 2001 From: Avital Oliver Date: Wed, 24 Apr 2013 09:55:59 -0700 Subject: [PATCH 2/2] accounts-github: Generate user agent string from release version --- packages/accounts-github/github_server.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/accounts-github/github_server.js b/packages/accounts-github/github_server.js index 6eb6987405..aa0a23bfc6 100644 --- a/packages/accounts-github/github_server.js +++ b/packages/accounts-github/github_server.js @@ -42,9 +42,13 @@ var getAccessToken = function (query) { }; var getIdentity = function (accessToken) { + var userAgent = "Meteor"; + if (Meteor.release) + userAgent += "/" + Meteor.release; + var result = Meteor.http.get( "https://api.github.com/user", { - headers: {"User-Agent": "Meteor/1.0"}, + headers: {"User-Agent": userAgent}, // http://developer.github.com/v3/#user-agent-required params: {access_token: accessToken} }); if (result.error) {