diff --git a/packages/domutils/domutils.js b/packages/domutils/domutils.js index 70379f364a..fdc7e6efb7 100644 --- a/packages/domutils/domutils.js +++ b/packages/domutils/domutils.js @@ -34,6 +34,8 @@ DomUtils = {}; // - apps that want jQuery's selector extensions (:visible, :input, etc.) // - apps that include jQuery anyway // - apps that want IE 7 support + // + // XXX others? zepto? var findAllBySelector = (window.Sizzle || (window.jQuery && window.jQuery.find) || qsaFindAllBySelector); diff --git a/packages/domutils/package.js b/packages/domutils/package.js index 23c9259a39..b50751a5d7 100644 --- a/packages/domutils/package.js +++ b/packages/domutils/package.js @@ -4,7 +4,14 @@ Package.describe({ }); Package.on_use(function (api) { + // XXX + // Doesn't actually require jQuery (but uses it if available). + // + // For now we are going to keep shipping jQuery with all apps + // so as not to break existing apps, but any time now we will + // cut this dependency. api.use('jquery', 'client'); + api.add_files('domutils.js', 'client'); }); diff --git a/packages/spark/package.js b/packages/spark/package.js index 98270c414e..2c28577c71 100644 --- a/packages/spark/package.js +++ b/packages/spark/package.js @@ -7,12 +7,6 @@ Package.on_use(function (api) { api.use(['underscore', 'uuid', 'domutils', 'liverange', 'universal-events'], 'client'); - // XXX Depends on jquery because we need a selector engine to resolve - // event maps. What would be nice is, if you've included jquery or - // zepto, use one of those; if not, ship our own copy of sizzle (but, - // you still want the event object normalization that jquery provides?) - api.use('jquery'); - api.add_files(['spark.js', 'patch.js', 'convenience.js'], 'client'); });