github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid log spam on deployed apps from websocket unless you're actually using

Browse Source 
server-to-server DDP.
This commit is contained in:
David Glasser
2013-04-12 10:56:52 -07:00
parent d1dd8a8e4d
commit d098b99bd8
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/livedata/stream_client_nodejs.js
View File

@@ -1,9 +1,3 @@
// WebSocket-Node https://github.com/Worlize/WebSocket-Node
// Chosen because it can run without native components. It has a
// somewhat idiosyncratic API. We may want to use 'ws' instead in the
// future.
var WebSocketClient = Npm.require('websocket').client;
// @param endpoint {String} URL to Meteor app
// "http://subdomain.meteor.com/" or "/" or
// "ddp+sockjs://foo-**.meteor.com/sockjs"
@@ -18,7 +12,22 @@ var WebSocketClient = Npm.require('websocket').client;
Meteor._DdpClientStream = function (endpoint) {
var self = this;
self.client = new WebSocketClient;
// WebSocket-Node https://github.com/Worlize/WebSocket-Node
// Chosen because it can run without native components. It has a
// somewhat idiosyncratic API. We may want to use 'ws' instead in the
// future.
//
// Since server-to-server DDP is still an experimental feature, we only
// require the module if we actually create a server-to-server
// connection. This is a minor efficiency improvement, but moreover: while
// 'websocket' doesn't require native components, it tries to use some
// optional native components and prints a warning if it can't load
// them. Since native components in packages don't work when transferred to
// other architectures yet, this means that require('websocket') prints a
// spammy log message when deployed to another architecture. Delaying the
// require means you only get the log message if you're actually using the
// feature.
self.client = new Npm.require('websocket').client;
self.endpoint = endpoint;
self.currentConnection = null;