From a4d5e95bb1439275ae898d83d61dab515c412e71 Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 9 Mar 2015 13:36:23 -0700 Subject: [PATCH 1/4] Revert "Make event handlers get called with target's view" This reverts commit 72887bb0ee95d3358846814f80117ec16b0c0eb9. --- packages/blaze/view.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/blaze/view.js b/packages/blaze/view.js index b8d429052f..05a1389d63 100644 --- a/packages/blaze/view.js +++ b/packages/blaze/view.js @@ -817,10 +817,9 @@ Blaze._addEventMap = function (view, eventMap, thisInHandler) { return null; var handlerThis = thisInHandler || this; var handlerArgs = arguments; - return Blaze._withCurrentView(Blaze.getView(evt.currentTarget), - function () { - return handler.apply(handlerThis, handlerArgs); - }); + return Blaze._withCurrentView(view, function () { + return handler.apply(handlerThis, handlerArgs); + }); }, range, function (r) { return r.parentRange; From 4dafb236affa5e571668a4b6cda558959cf1186d Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 9 Mar 2015 13:37:45 -0700 Subject: [PATCH 2/4] Change documentation for Template.currentData in events --- packages/blaze/template.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/blaze/template.js b/packages/blaze/template.js index fddef8f4ed..a12f9e15ca 100644 --- a/packages/blaze/template.js +++ b/packages/blaze/template.js @@ -490,10 +490,10 @@ Template.instance = function () { * * - Inside an `onCreated`, `onRendered`, or `onDestroyed` callback, returns * the data context of the template. + * - Inside an event handler, returns the data context of the template on which + * this event handler was defined. * - Inside a helper, returns the data context of the DOM node where the helper * was used. - * - Inside an event handler, returns the data context of the element that fired - * the event. * * Establishes a reactive dependency on the result. * @locus Client From a6d4e984078fa9198a3c6d9fc0dc67792aa61ade Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 9 Mar 2015 13:39:44 -0700 Subject: [PATCH 3/4] Revert "Tests for `Template.currentData` and `Template.parentData`" This reverts commit f2840103ca23dedd458524ad4e01609069ce28cb. Conflicts: packages/spacebars-tests/template_tests.html packages/spacebars-tests/template_tests.js --- packages/spacebars-tests/template_tests.html | 8 --- packages/spacebars-tests/template_tests.js | 52 -------------------- 2 files changed, 60 deletions(-) diff --git a/packages/spacebars-tests/template_tests.html b/packages/spacebars-tests/template_tests.html index fd1d469eb4..6ff3a5582a 100644 --- a/packages/spacebars-tests/template_tests.html +++ b/packages/spacebars-tests/template_tests.html @@ -1028,14 +1028,6 @@ Hi there! {{> Template.contentBlock}} - -