From dceef1461c74b7f4ccf9b451db655b68ea2fb09f Mon Sep 17 00:00:00 2001 From: Avital Oliver Date: Wed, 16 Jan 2013 16:00:37 -0800 Subject: [PATCH] Minor changes from code review --- lib/files.js | 2 +- lib/packages.js | 4 +--- lib/run.js | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/files.js b/lib/files.js index 219ea01f21..3aa61df335 100644 --- a/lib/files.js +++ b/lib/files.js @@ -130,7 +130,7 @@ var files = module.exports = { // for a packge that exists in localPackageDirs, find the directory // in which it exists - localPackageDir: function(name) { + directoryForLocalPackage: function(name) { var ret; _.find(this.localPackageDirs(), function(packageDir) { var dir = path.join(packageDir, name); diff --git a/lib/packages.js b/lib/packages.js index 6d762ef265..d25d45045d 100644 --- a/lib/packages.js +++ b/lib/packages.js @@ -97,7 +97,7 @@ _.extend(Package.prototype, { // - $METEOR/packages // @returns {Boolean} was the package found in any local package sets? initFromLocalPackages: function (name) { - var packageDir = files.localPackageDir(name); + var packageDir = files.directoryForLocalPackage(name); if (packageDir) { this._initFromPackageDir(name, packageDir); return true; @@ -234,8 +234,6 @@ _.extend(Package.prototype, { } }); -// (OLD COMMENT?) in the future, this could be an on-disk cache that -// tracks mtimes. var compiledPackages = {}; var packages = module.exports = { diff --git a/lib/run.js b/lib/run.js index 273f613966..706bde5ec1 100644 --- a/lib/run.js +++ b/lib/run.js @@ -339,7 +339,7 @@ var DependencyWatcher = function (deps, app_dir, relativeFiles, on_change) { self.specific_files = {}; for (var pkg in (deps.packages || {})) { _.each(deps.packages[pkg], function (file) { - self.specific_files[path.join(files.localPackageDir(pkg), file)] + self.specific_files[path.join(files.directoryForLocalPackage(pkg), file)] = true; }); };