From ecdfd3c610fbe5334eee024702fe0c354944f58b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nacho=20Codo=C3=B1er?= Date: Wed, 27 Mar 2024 17:36:06 +0100 Subject: [PATCH] silent last extra uncaught promise --- .../ddp-client/client/queueStubsHelpers.js | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/packages/ddp-client/client/queueStubsHelpers.js b/packages/ddp-client/client/queueStubsHelpers.js index acad7e58ac..bedbaa082f 100644 --- a/packages/ddp-client/client/queueStubsHelpers.js +++ b/packages/ddp-client/client/queueStubsHelpers.js @@ -21,15 +21,17 @@ export const loadAsyncStubHelpers = () => { queue = queue.finally(() => { fn(resolve, reject); - return promise.stubPromise?.catch(() => {}); + return promise.stubPromise?.catch(() => {}); // silent uncaught promise }); - promise.catch(() => {}).finally(() => { - queueSize -= 1; - if (queueSize === 0) { - Meteor.connection._maybeMigrate(); - } - }); + promise + .catch(() => {}) // silent uncaught promise + .finally(() => { + queueSize -= 1; + if (queueSize === 0) { + Meteor.connection._maybeMigrate(); + } + }); promise.stubPromise = promiseProps.stubPromise; promise.serverPromise = promiseProps.serverPromise; @@ -100,11 +102,12 @@ export const loadAsyncStubHelpers = () => { hasStub = !!applyAsyncPromise.stubPromise; if (hasStub) { applyAsyncPromise.stubPromise - .catch(() => {}) + .catch(() => {}) // silent uncaught promise .finally(() => { finished = true; }); } + applyAsyncPromise .then((result) => { resolve(result); @@ -112,6 +115,7 @@ export const loadAsyncStubHelpers = () => { .catch((err) => { reject(err); }); + serverPromise.catch(() => {}); // silent uncaught promise }); Meteor._setImmediate(() => {