From f0460a39dc15d39712088ea50618943c46bb43ce Mon Sep 17 00:00:00 2001 From: David Greenspan Date: Mon, 31 Aug 2015 11:47:08 -0700 Subject: [PATCH] Don't suggest updates to core pkg indirect deps Exclude core packages (whose versions are pinned) from being printed when we say: "Newer versions of the following indirect dependencies are available". --- tools/cli/commands-packages.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/cli/commands-packages.js b/tools/cli/commands-packages.js index 3f46f9770e..68f8a08d43 100644 --- a/tools/cli/commands-packages.js +++ b/tools/cli/commands-packages.js @@ -1668,13 +1668,23 @@ main.registerCommand({ if (!options.args.length) { // Generate and print info about what is NOT at the latest version. - var topLevelPkgSet = {}; + + var topLevelPkgSet = {}; // direct dependencies (rather than indirect) projectContext.projectConstraintsFile.eachConstraint(function (constraint) { topLevelPkgSet[constraint.package] = true; }); + + var releaseConstrainedPkgSet = {}; // pinned core packages (to skip) + _.each(releaseRecordForConstraints.packages, function (v, packageName) { + releaseConstrainedPkgSet[packageName] = true; + }); + var nonlatestDirectDeps = []; var nonlatestIndirectDeps = []; projectContext.packageMap.eachPackage(function (name, info) { + if (_.has(releaseConstrainedPkgSet, name)) { + return; + } var selectedVersion = info.version; var catalog = projectContext.projectCatalog; var latestVersion = getNewerVersion(name, selectedVersion, catalog);