From f404f282753fd4bb2f02b9761485dc7f7146aebf Mon Sep 17 00:00:00 2001 From: David Glasser Date: Tue, 18 Nov 2014 14:02:07 -0800 Subject: [PATCH] Use simpler query for getSortedVersions The old one read and parsed JSON blobs from sqlite instead of just using pre-existing columns. --- tools/catalog-remote.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tools/catalog-remote.js b/tools/catalog-remote.js index 09bd55a928..00e7725af3 100644 --- a/tools/catalog-remote.js +++ b/tools/catalog-remote.js @@ -564,7 +564,8 @@ _.extend(RemoteCatalog.prototype, { getSortedVersions: function (name) { var self = this; - var match = this._getPackageVersions(name); + var match = this._columnsQuery( + "SELECT version FROM versions WHERE packageName=?", name); if (match === null) return []; return _.pluck(match, 'version').sort(VersionParser.compare); @@ -593,14 +594,6 @@ _.extend(RemoteCatalog.prototype, { return result[0]; }, - _getPackageVersions: function (name) { - if (!name) { - throw new Error("No name provided"); - } - return this._contentQuery( - "SELECT content FROM versions WHERE packageName=?", name); - }, - getAllBuilds: function (name, version) { var result = this._contentQuery( "SELECT * FROM builds WHERE builds.versionId = " +