From fa4e9c676efa74f268a0649ee09a6cfaf3f6e9ad Mon Sep 17 00:00:00 2001 From: Netanel Gilad Date: Mon, 12 Jan 2015 00:33:34 +0200 Subject: [PATCH] add body attributes tests --- packages/templating/plugin/html_scanner.js | 2 +- packages/templating/scanner_tests.js | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/templating/plugin/html_scanner.js b/packages/templating/plugin/html_scanner.js index c45a3b1f86..b45b6d3dd9 100644 --- a/packages/templating/plugin/html_scanner.js +++ b/packages/templating/plugin/html_scanner.js @@ -172,7 +172,7 @@ html_scanner = { } else { // if (hasAttribs) { - for(var attr in attribs) {p + for(var attr in attribs) { if (this.bodyAttributes.indexOf(attr) !== -1) { console.log('WARNING: tag ' + attr + ' already defined on body.'); } diff --git a/packages/templating/scanner_tests.js b/packages/templating/scanner_tests.js index 3d49e63939..8e328eabbc 100644 --- a/packages/templating/scanner_tests.js +++ b/packages/templating/scanner_tests.js @@ -112,6 +112,9 @@ Tinytest.add("templating - html scanner", function (test) { 'pizza'), simpleTemplate('"the \\"cool\\" template"', '"pizza"')); + checkResults(html_scanner.scan('\n Hello\n'), + "\nMeteor.startup(function() { $('body').attr({\"foo\":\"bar\"}); });\n" + simpleBody('"Hello"')); + // error cases; exact line numbers are not critical, these just reflect // the current implementation @@ -153,11 +156,6 @@ Tinytest.add("templating - html scanner", function (test) { ''); }, "DOCTYPE", 1); - // attributes on body not supported - checkError(function() { - return html_scanner.scan('\n Hello\n'); - }, "", 1); - // attributes on head not supported checkError(function() { return html_scanner.scan('\n Hello\n');