Commit Graph

9 Commits

Author SHA1 Message Date
Matthew Brewer
6980ff73d1 Make awscli actually work for copy scripts.
Remove the leading / from the regex, which doesn't exist with awscli
2015-03-25 10:12:50 -04:00
Matthew Brewer
b5b78c5da8 Add a comment explaining 'wc -l' 2015-02-10 15:53:33 -05:00
Matthew Brewer
7436784e2e Switch s3cfg to aws cli
This serves server purposes
1) aws cli can do a lot more htings, so this is fewer tools we have to use
2) this uses the same key format as we're already using for everything else
3) because of key format, we can easilly switch to everyone using their own keys

Note that after this is commited you will have to set up aws cli to use this script.
See: https://mdg.hackpad.com/Operational-Suggestions-and-tips-EZFrKK81iHf#:h=AWS-management
2015-02-10 13:49:07 -05:00
Slava Kim
af50216007 Add a trap 2015-01-20 22:06:58 -08:00
Slava Kim
7253c8ee9c increase the number of expected tarballs in "copy from jenkins" script 2015-01-20 22:06:58 -08:00
David Glasser
6d2408f52b copy-dev-bundle-from-jenkins: don't overwrite! 2014-06-25 14:56:37 -07:00
Felix Rabe
3431c66c16 Fix occurrences of "cd dirname $0"
They are not safe for spaces in paths. There might be other places to look for trouble.

I've run the following command to produce this commit: (on OS X, copy-and-pasting the below exactly)

    find . -type f -name '*.sh' -print0  |  # Find all .sh files
        xargs -0 fgrep -H -- '`'         |  # See all places with backticks in them
        fgrep 'cd `dirname $0'           |  # I deemed these problematic (variable assignments are safe)
        cut -d ':' -f 1                  |  # Take the <file> from <file>:<line> produced by "grep -H"
        tr '\n' '\0'                     |  # Also here, spaces can be problematic - always do "xargs -0"!
        xargs -0 -- sed -i '' 's/cd `dirname $0`/cd "`dirname "$0"`"/g'

The significance of adding the two levels of "'s can be verified by running the following in your Terminal:

    $ node -e 'console.log(process.argv.splice(1))' -- `echo 1   2`
    [ '1', '2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo 1   2`"
    [ '1 2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo "1   2"`"
    [ '1   2' ]
2014-05-07 17:51:09 -07:00
David Glasser
4e4e5add87 chmod +x and fix bug in new script 2013-06-10 15:47:56 -07:00
David Glasser
e72c7472a8 Restore copy from jenkins script, this time for dev bundle 2013-06-10 13:18:32 -07:00