Commit Graph

14 Commits

Author SHA1 Message Date
David Glasser
ddc3657e4f Watch files which fail before emitting a resource
Regression introduced by the CSS watching code (specifically, f230eba62)
by the sourceIsWatched check. We need to be able to tell the difference
between "source handler didn't do anything because there was an error"
and "source handler didn't do anything because it's web-specific and
this is an os arch".

A simple fix would have been to interpret compileStep.error as
"sourceIsWatched = true", but I didn't think of that until after doing
it the slightly more complicated but more precise way :)

Also, ensure that if the runner rebuilds the client and there's an
error, it properly kills the app process (and the watchers and the
keepalive interval, etc).
2014-08-04 21:32:22 -07:00
Matthew Arbesfeld
8bcbd65344 Separate "browser" target into web.browser/cordova
Cordova projects often have a different set of files than web targets,
so we would like to be able to target different client architectures in
our bundles. Ideally, we allow the user to use arbitrary client
architectures - but this patch is a step in the right direction by
abstracting out more of the hard coded "browser"/"os" lines.

We accomplish this separation in a backwards compatible way by allowing
api.___ commands to target a "client" architecture. For example,
api.addFiles('a.js', 'client') adds 'a.js' to both the 'client.browser'
and 'client.cordova' targets.

Effects on 0.9 packaging stuff: packages don't have to change, but the
"data.json" file in ".meteor0" has "browser" in some places. We think we
have to fix the troposphere code where this data.json is created.

Some plugins will also be backwards-incompatible with this change, since
many have a "clientArch.matches("browser")" line in the plugin
code. Ideally, we fix plugins so that this stops being an issue, but for
now package authors can just patch that line.

At the compiled (unipackage) level the new names are 'web.browser' and
'web.cordova', replacing 'browser'. In package.js, the new names are
'client.browser' and 'client.cordova', serving as an adjunct to 'client'.
2014-07-31 14:12:15 -07:00
Cangit
dbca6908f3 Don't decrement the line number in LESS error reporting.
LESS fixed their math problem in 1.6.0
2014-06-10 09:45:03 -07:00
Slava Kim
3d7448bcce Pass the filepath to less parser 2014-04-06 15:36:05 -07:00
David Glasser
c0447737ec Fix less error handling during ast.toCSS
Fixes #1877
2014-03-03 21:55:58 -08:00
Slava Kim
dc4eb4c496 Prevent less sourcemaps generation hanging w/o compiling less twice 2014-02-20 00:03:15 -08:00
Slava Kim
3caa824b32 Don't hang if less produces no source-map
Add a test for that
2014-02-19 22:03:14 -08:00
Slava Kim
a26822ec96 Style fixes, renames, comments 2014-02-05 13:54:30 -08:00
Maxime Quandalle
cf11139f6c Add a .import.styl handler to prevent Meteor processing a stylus file Fix #462 2014-02-03 21:58:29 -08:00
Slava Kim
efb700f4f9 Rename futures for less package 2014-02-03 21:58:29 -08:00
Maxime Quandalle
57e670440a less package ignores .import.less files, so you can import them and still haves syntax highlighting in your text editor. 2014-02-03 21:58:28 -08:00
Slava Kim
2f78babda1 Enable less sourcemaps 2014-02-03 21:58:28 -08:00
David Glasser
c3d1f7bbd2 Don't fail if stylus or less files are in a non-client-specific place.
Make the plugin's arch check less sketchy.

Improve less and stylus error handling.
2013-08-02 15:16:53 -07:00
Geoff Schmidt
4bff34a680 Port 'less' package to new plugin API 2013-05-13 11:52:43 -07:00