Commit Graph

17 Commits

Author SHA1 Message Date
Justin SB
0e79787c17 Make 'meteor run' pretty 2014-09-24 15:53:05 -07:00
Justin SB
555bd231eb Change the 'easy' instances of rawLog to use Console
Rationalizing logging is definitely a TODO
2014-09-24 15:53:05 -07:00
David Glasser
08a6fa99fd Don't use _.once or instanceof with uniload
_.once has the problem that if you call the once'd function while it is
still in progress (re-entrantly or in another Fiber), it returns
undefined immediately.  That's bad for uniload! uniload already has a
cache, so just use that.  (In the future, perhaps detect an attempt to
uniload something that's currently in the process of being uniloaded in
another fiber and block until the other fiber is ready.)

Using instanceof with things you've uniloaded is a little sketchy: maybe
two different uniload calls will end up with two different copies of
Package.meteor.Meteor.Error, and it seems kind of hairy to ensure you're
not mixing and matching copies.  However, Meteor.Errors are all tagged
with a string errorType, which fills me with much less fear,
uncertainty, and doubt than instanceof.
2014-08-17 23:37:38 -07:00
Matthew Arbesfeld
f230eba62b Client CSS and template injection. 2014-07-09 10:31:44 -07:00
David Glasser
fbde0a00a7 Merge branch 'publish-packages' into library-refactor
Conflicts:
	packages/domutils/package.js
	packages/handlebars/package.js
	packages/htmljs/package.js
	packages/liverange/package.js
	packages/spark/package.js
	packages/universal-events/package.js
	tools/bundler.js
	tools/help.txt
	tools/packages.js
	tools/run-app.js
	tools/run-mongo.js
	tools/skel/.meteor/packages
2014-04-24 17:01:36 -07:00
David Glasser
3e76ad7946 Don't use require('./run-log.js').runLog
If you happen to introduce a circular require into the stack, this
object will be undefined.

Instead, hang on to `require('./run-log.js')`, which is the exports
module which does get filled in later.
2014-03-31 19:52:02 -07:00
Geoff Schmidt
688f7b3643 rename unipackage.load to uniload.load 2014-03-13 21:47:12 -07:00
Geoff Schmidt
3f8beb0935 unipackage.load no longer takes a library 2014-03-11 14:42:42 -07:00
David Glasser
20a8e679f7 use runLog in updater
Note that this can stomp on, eg, "Starting your app".
2014-02-13 19:37:55 -08:00
David Glasser
1f7fa9e4c4 a comment about runlog 2014-02-13 19:37:55 -08:00
David Glasser
2586a50cd0 Refactor RunLog to be a singleton
The rationale: RunLog is an object that is hardcoded around managing two
other singletons: stdout and stderr. Having multiple RunLogs wouldn't
work well without improving RunLog to have the ability to control other
streams.

We'd like to be able to use RunLog from other places in the tool, most
notably from code called from bundler (while running an app) such as the
npm updater. But threading a RunLog object through that code is
difficult (especially as bundling takes a detour through
release.current.library).
2014-02-13 19:11:30 -08:00
David Glasser
4f71c56531 Don't drop empty lines from app stdout/err
(This was not a tool-refactoring change.)
2014-02-07 19:00:04 -08:00
Geoff Schmidt
377d940ba0 fake-mongod, a stub mongod for automated testing 2014-01-28 19:36:04 -08:00
Geoff Schmidt
be0a11802d Print progress messages on startup. Fix some bugs. 2014-01-07 16:55:58 -08:00
Geoff Schmidt
9813345e15 move runMongoShell to appropriate file. fix some bugs. 2014-01-06 23:30:19 -08:00
Geoff Schmidt
7522005575 runner refactor - WIP (rejigger runOnce/entry point)
getting into pretty good shape now!
2014-01-04 04:08:54 -08:00
Geoff Schmidt
088d70da36 runner refactor - WIP (break runner.js up into several files) 2014-01-03 20:36:13 -08:00