Commit Graph

33 Commits

Author SHA1 Message Date
ekatek
b9a714f028 ripping out internal, name and test from package.js files 2014-07-07 20:50:50 -07:00
ekatek
fb709c9563 remove versions files from core packages 2014-06-16 22:11:31 -07:00
David Glasser
e4000c6808 Merge branch 'devel' into packaging
Conflicts (around utils.quotemeta):
	tools/packages.js
	tools/utils.js
2014-05-12 17:06:11 -07:00
ekatek
beb0e59b9d new version files from teh new solver? Also, package.js correct with tests 2014-05-09 17:36:25 -07:00
Emily Stark
0c479a238b Add credential secret argument to retrieveCredential functions.
Fixes #2118.
2014-05-05 20:51:15 -07:00
ekatek
031890d2c5 don't store buildtime deps in the catalog 2014-05-04 16:56:58 -07:00
ekatek
23ad149a78 better versions files 2014-04-25 15:06:45 -07:00
ekatek
10d2047d12 clean up 2014-04-25 15:01:20 -07:00
ekatek
c84c8d6097 alphabetize package version lock files 2014-04-24 18:18:21 -07:00
David Glasser
3b21c2d9a7 Merge branch 'devel' into publish-packages
Conflicts:
	packages/domutils/package.js
	packages/handlebars/package.js
	packages/htmljs/package.js
	packages/liverange/package.js
	packages/madewith/package.js
	packages/meteor-developer/meteor_developer_server.js
	packages/preserve-inputs/package.js
	packages/spark/package.js
	packages/universal-events/package.js
	tools/commands.js
	tools/files.js
	tools/help.txt
	tools/packages.js
2014-04-24 16:27:21 -07:00
Emily Stark
55363a9b86 Merge remote-tracking branch 'origin/devel' into awwx-oauth-encryption
Conflicts:
	History.md
	packages/facebook/facebook_client.js
	packages/github/github_client.js
	packages/google/google_client.js
	packages/meetup/meetup_client.js
	packages/meteor-developer/meteor_developer_client.js
	packages/twitter/twitter_client.js
	packages/weibo/weibo_client.js
2014-04-22 11:31:31 -07:00
David Glasser
8c38550315 Improve error message for pre-config login
Addresses #2048.

An earlier attempt (to wait for the config to load) ran into popup
blockers.

It would be nice to load the config statically with something like
Arunoda's fast-render. That said, even that's not good enough to allow
OAuth logins that bypass the popup blocker that aren't a result of a
user action, and for user actions it's easy enough to gate your login
button on `Accounts.loginServicesConfigured()`.

Longer term solutions include non-popup methods of OAuth login (see
Issue #438).
2014-04-21 13:39:36 -07:00
David Glasser
a251255001 Revert "Meteor.loginWith<External> now waits for config"
This reverts commit 76ded8feb2.
2014-04-21 13:39:36 -07:00
Emily Stark
66b73e170e Merge branch 'oauth-encryption' of https://github.com/awwx/meteor into awwx-oauth-encryption
Conflicts:
	packages/facebook/facebook_client.js
	packages/github/github_client.js
	packages/google/google_client.js
	packages/meetup/meetup_client.js
	packages/meteor-developer/meteor_developer_client.js
	packages/oauth/pending_credentials.js
	packages/twitter/twitter_client.js
	packages/weibo/weibo_client.js
2014-04-21 11:08:43 -07:00
David Glasser
76ded8feb2 Meteor.loginWith<External> now waits for config
While this could mean that there's an indefinite wait before logging you
in, any condition where login configuration isn't being swiftly
published (after all, it should be cached) is a bigger problem.

`Accounts`/accounts-base is an awkward place to put this, because in
theory we wanted the packages like "twitter" to not depend on
accounts. But it turns out that service-configuration depends on
accounts anyway, so this isn't much of a regression. We can't put this
function in service-configuration because that package doesn't actually
do the subscription and make the ready handle. (Maybe oauth would be a
better place, but again, that's a package that doesn't currently depend
directly on accounts-base and would have to.)

Fixes #1911 and #2048.
2014-04-18 15:09:59 -07:00
Emily Stark
e544a8e03a Increase length of security-critical random tokens. Add Random.secret. 2014-04-17 16:12:16 -07:00
Andrew Wilcox
83af2e2179 oauth-encryption code review items
Have `OAuthEncryption.open` throw "decryption unsuccessful" on any
error to avoid allowing an attacker to break the encryption key by
observing the result of sending manipulated ciphertexts.

Add oauth-encryption and the oauthSecretKey config options to the docs
page.

Update history.

More documentation on functions.

Use `OAuth.sealSecret(...)` instead of `{seal: ...}`.

Rename OAuth._openSecret(s) to OAuth.openSecret(s).

In the readme describing how to generate a key, just use Node instead
of going through the hassle of creating a Meteor application.

Have the `oauth` package weakly depend on `oauth-encryption` for when
it's being used without accounts.

Add tips on using oauth-encryption without accounts to the readme.
2014-04-10 14:26:44 -04:00
Andrew Wilcox
d365f052f5 Encrypt account service configuration and OAuth secrets stored in the
database.

"Oauth" is renamed to "OAuth".  "Oauth" is kept as an alias for
backwards compatibility.

README.md contains a sample description of how to generate and use the
oauthSecretKey, which might be incorporated into the wiki
documentation page.
2014-04-08 18:57:58 -04:00
Geoff Schmidt
66b7253695 Take all packages to 1.0.0 (that aren't already there) 2014-03-07 12:00:20 -08:00
Emily Stark
d573464f92 Rename Oauth.initiateLogin to Oauth.showPopup. 2013-11-20 11:26:51 -08:00
Tim Haines
723e4b5b50 Attach response object to accounts generated errors resulting from HTTP failures 2013-08-06 11:37:05 -07:00
David Glasser
4b3cb9d305 Rename api.exportSymbol -> api.export. 2013-07-25 18:54:43 -07:00
David Glasser
a5c061ecde Rename Meteor.http to HTTP. Backwards compatible. 2013-07-25 18:54:42 -07:00
David Glasser
9f38258b54 Drop all @export lines. Add api.exportSymbol instead. 2013-07-25 18:54:40 -07:00
Geoff Schmidt
d2024ccee1 Clean up namespacing in accounts system too. 2013-07-25 18:54:40 -07:00
David Glasser
c51ea9c9c0 Update Github instructions.
https://github.com/blog/1523-oauth-improvements
2013-07-15 21:49:08 -07:00
David Glasser
cebf6924bb Lots of missing dependencies, mostly in accounts code. 2013-06-25 09:53:42 -07:00
David Glasser
729e53171d More linker fixes from the OAuth refactor. 2013-05-28 15:56:58 -07:00
David Glasser
d757b366d2 More fixes, from the merge of devel into linker.
Mostly related to making the big OAuth refactoring linker-friendly.
2013-05-28 15:52:50 -07:00
Nick Martin
44ac53f819 Tweak package descriptions. 2013-05-17 21:01:14 -07:00
Tim Haines
a3f493bb79 Add retrieveCredential server methods 2013-05-17 21:01:14 -07:00
Tim Haines
00efa2fe51 Update requestCredential method to take only 2 params - options and credentialRequestCompleteCallback 2013-05-17 18:00:35 -07:00
Tim Haines
107a06fd8c Extract github package from accounts-github 2013-05-17 18:00:35 -07:00