Commit Graph

4356 Commits

Author SHA1 Message Date
David Glasser
43b1c30bab Be clearer that you need to publish for this arch
Fixes #3961.
2015-03-26 17:19:31 -07:00
David Glasser
da87051f34 meteor shell should preserve global _
2443d832 (in 1.0.4) ensures that the repl doesn't overwrite `_`, but it
replaces the server's global `_` with shell-server's `_`.  This changes
appears to preserve it.

Fixes #4010.
2015-03-26 14:53:47 -07:00
David Glasser
d226fd18af Plugins register extensions, not filenames
This particular piece of code (introduced in #1407) would decide that
Plugin.registerSourceHandler('foo.bar') would match a file named
'foo.bar', but that was not the intention. In an app, the (correct) code
in getSourcesFunc does expect the leading period to exist, so you end up
with an odd situation where this code allows equal matches, but it only
gets to see the file if it's in a package (not app) or if there's
another plugin registering for 'bar'.

Fixes #3985.
2015-03-26 13:56:29 -07:00
Sashko Stubailo
39b11ca456 Merge branch 'master' into devel
Conflicts:
	History.md
2015-03-25 14:58:21 -07:00
Sashko Stubailo
f9906346db Remove WINDOWS-PREVIEW hack
So that there is a recommended release published for Windows

Conflicts:
	tools/utils.js
2015-03-24 17:21:59 -07:00
ekatek
f4e2e2aab9 Better error display in package-client
Addressing: https://github.com/meteor/meteor/issues/3977

HttpHelpers.getUrl sometimes throws an error, and sometimes throws a string. The right
thing to do is to fix getUrl everywhere, but for now, let's get better error handling
in package-client.js
2015-03-24 14:38:46 -07:00
Jonas Aschenbrenner
63df4b1ce5 Velocity timing and mirror url fix
Velocity has visited the mirror sometimes before
it is ready. With this new check that is already
used in the testing frameworks this no longer
happens.

This commit also handles the upcoming breaking
change regarding the rootUrl of the mirror.
See: https://github.com/meteor-velocity/velocity/issues/260
2015-03-24 13:53:40 -07:00
David Glasser
ab2e629239 Upgrader for Facebook API change. 2015-03-23 14:57:54 -07:00
David Glasser
ab9ef40d25 Upgrader for Facebook API change. 2015-03-23 12:02:24 -07:00
David Glasser
aa2867b3ea Clean up Cordova app IDs a bit
Starting with cordova-lib 4.2.0 (shipped with Meteor 1.0.4) the cordova
create command checks that app IDs look like Java namespaces.  Clean up
the most obvious ways that our generated app IDs won't look like Java
namespaces (most notably hyphens).

This isn't perfect (eg we don't check for leading digits or
consecutive/leading/trailing dots, or for Java reserved words).  This
check is implemented by the valid-identifier NPM package.

While we're at it, put app ids under `com.meteor.userapps` so that there
are other parts of `com.meteor` available for potential MDG Java work.

Fixes #3950.
2015-03-20 11:11:44 -07:00
David Glasser
dabe0ae2f0 Clean up Cordova app IDs a bit
Starting with cordova-lib 4.2.0 (shipped with Meteor 1.0.4) the cordova
create command checks that app IDs look like Java namespaces.  Clean up
the most obvious ways that our generated app IDs won't look like Java
namespaces (most notably hyphens).

This isn't perfect (eg we don't check for leading digits or
consecutive/leading/trailing dots, or for Java reserved words).  This
check is implemented by the valid-identifier NPM package.

While we're at it, put app ids under `com.meteor.userapps` so that there
are other parts of `com.meteor` available for potential MDG Java work.

Fixes #3950.
2015-03-20 11:03:36 -07:00
Avital Oliver
e95cc58031 Fix publish-for-arch in Windows
We recently changed the package tarball structure to use
colonConverter in package-client.js but not in
commands-package.js
2015-03-18 00:26:38 -07:00
David Glasser
21bdac8734 Merge branch 'master' into devel
Conflicts:
	History.md
	packages/accounts-password/package.js
	packages/accounts-password/password_server.js
	packages/constraint-solver/package.js
	packages/meteor-tool/package.js
	packages/non-core/npm-bcrypt/package.js
	packages/package-version-parser/package-version-parser-tests.js
	packages/package-version-parser/package-version-parser.js
	packages/package-version-parser/package.js
	tools/selftest.js
2015-03-17 13:41:14 -07:00
David Glasser
8409919bb6 actually fail on package creation error 2015-03-17 12:14:16 -07:00
David Glasser
cfb21f43e5 Move third-party licenses into subdirectory
This should make them easier to update.
2015-03-17 11:18:57 -07:00
Sashko Stubailo
efdfe62331 Validate number of colons in package name on create
Instead of in the general package version parser
2015-03-17 10:56:33 -07:00
David Greenspan
269f32fec6 Fix package-tests: package specifying a name
a self-test broken by the version solver changes.
2015-03-16 16:18:02 -07:00
David Glasser
d591a288e1 Fix Android emulator access
Also fix odd use of `false` where everything else used `true`.
2015-03-13 18:49:30 -07:00
David Greenspan
6261fc2de7 Let meteor update --release downgrade packages
When the tool runs the constraint solver to see what releases can
be chosen, it creates its own ProjectContext and does not pass
command-line flags through.  Additionally, if the release you ask
for is not possible to choose for whatever reason (constraints in
.meteor/packages, and now the guard against downgrading root
dependencies), the error is swallowed and a pleasant "success"
message is printed.  We should probably fix this at some point.

For now, `meteor update --release` just runs the constraint solver
as if `--allow-incompatible-update` was passed, which effectively
means it gets to ignore `.meteor/versions` if necessary.
2015-03-13 11:28:48 -07:00
David Greenspan
1b85b8205e Enable detailed profiling of the constraint solver
See the report using METEOR_PROFILE=1
2015-03-13 10:47:52 -07:00
Slava Kim
171e10a87f Create ssh files in a temp dir assigned by files.js
and not in /tmp
2015-03-12 22:59:28 -07:00
Slava Kim
6dede19a60 Clear screen before dropping into a Windows ssh 2015-03-12 22:46:58 -07:00
Avital Oliver
7b8748e11d Change result of meteor --version on Windows
It now actually prints the "WINDOWS-PREVIEW" track on which
it is released.
2015-03-12 21:09:14 -07:00
Avital Oliver
942db816ca Add windows arch to two lists 2015-03-12 19:49:24 -07:00
David Greenspan
83dc85478f Add "Select Package Versions" to METEOR_PROFILE
There's no detail yet, but I'm going to add some.  In the mean time,
you just get the total ms for "Selecting Package Versions...", and
if it runs a second time you'll get another report for "(Try 2)"!
2015-03-12 18:12:01 -07:00
Sashko Stubailo
c6ea68f9b3 Make meteor create --package not use prefix
It used to create a directory with an underscore instead of a colon
Now, it just removes the prefix.

In cases where the name of the package has more than one colon or starts or ends
witha colon, we report an error.
2015-03-12 17:57:27 -07:00
David Greenspan
a75b0a441a Remove dead code from profile.js 2015-03-12 17:21:30 -07:00
David Greenspan
7c245285fe meteor update with no args patches indirect deps
With this change, `meteor update` with no arguments, in addition to
updating direct dependencies, updates patch versions of indirect
dependencies, so you will get your version 1.4.2 in the above example.

Background: As of the new solver, we already prefer patched versions 
when selecting a version for a new indirect dependency.  For example,
if 1.4.0 is the oldest version we could choose, we will take 1.4.1
instead if available.  However, if 1.4.2 came out, there would never
be an occasion to take it, unless you explicitly typed
`meteor update the-indirect-dependency`.  `meteor update` with no
args expands to `meteor update <all direct deps>`.

Also improve comments, tests, and code around CS.Input.
2015-03-12 16:24:05 -07:00
Avital Oliver
89f86b1b7c Fix publish-for-arch in Windows
We recently changed the package tarball structure to use
colonConverter in package-client.js but not in
commands-package.js
2015-03-12 12:47:56 -07:00
Sashko Stubailo
1b761260c1 Don't try to create a dir with package name
This fails on windows because of colon, plus it's a good idea to make these
names as short as possible for path length
2015-03-12 12:26:46 -07:00
David Glasser
ec026e3b60 Work around a cordova bug
Fixes #3914.  Fixes self-test 'add cordova plugins'.
2015-03-11 17:46:17 -07:00
David Glasser
34df238362 Delete "sync local catalog" test
It's been auto-failing for many months. If somebody wants to fix it,
feel free to revert this and fix it, but there's no reason to just
entirely stop self-test --slow from having any hope of passing forever.
2015-03-11 17:46:17 -07:00
David Glasser
55ab7f16c6 test: Prevent overlapping meteor calls
They crashed sometimes, because meteor does that.
2015-03-11 17:46:16 -07:00
ekatek
43d6be6734 fixing a test
The test is fine, but we were publishing a different version than we checked for.
(That is, we published 1.1.0, and were surprised when 1.0.1 did not show up).
Fixed.
2015-03-11 17:46:16 -07:00
David Glasser
031237573a Work around a cordova bug
Fixes #3914.  Fixes self-test 'add cordova plugins'.
2015-03-10 21:48:20 -07:00
David Glasser
52d500e123 Delete "sync local catalog" test
It's been auto-failing for many months. If somebody wants to fix it,
feel free to revert this and fix it, but there's no reason to just
entirely stop self-test --slow from having any hope of passing forever.
2015-03-10 20:54:22 -07:00
David Greenspan
0e53947a21 Don't refresh on package-version-parser error 2015-03-10 14:34:05 -07:00
David Greenspan
08bc9ab002 Nicer errors when tool encounters bad package name
Verified manually that `meteor update asdf.` displays an error,
not a stack trace.

Include the offending name in all error messages (as we do for
invalid versions).
2015-03-10 13:58:27 -07:00
Mitar
0bf0f75c6d Increase the stdout/stderr buffer for npm install.
Otherwise for some npm packages which output a lot during install, installation simply fails with no clear error message. node.js kills the process and there is no information about that in anything Meteor prints out: "maxBuffer specifies the largest amount of data allowed on stdout or stderr - if this value is exceeded then the child process is killed."
2015-03-10 13:53:57 -07:00
Mitar
f2dfcfd7e1 Duplicate import. 2015-03-10 13:41:33 -07:00
David Greenspan
3d64b13555 Give more commands "--allow-incompatible-change"
build, deploy, --prepare-app, and --get-ready for now.

Make the error message more generic (not mention which commands
support the flag, because it will be basically "all" of them). Also
replace "breaking" with "potentially incompatible" as discussed with
Matt a while back.
2015-03-10 03:50:41 -07:00
David Greenspan
6aad026dcf Merge remote-tracking branch 'origin/devel' into use-logic-solver
Conflicts:
	packages/constraint-solver/package.js
	packages/package-version-parser/package.js
2015-03-10 01:43:19 -07:00
David Greenspan
e7702f284e Change --breaking to --allow-incompatible-update 2015-03-10 01:37:58 -07:00
David Glasser
f207371bc0 Revert "Add some helpers for testing wrapped text"
This reverts commit 4a6dd52bca.

This made some tests flaky because notSpaceSensitive sometimes (but not
always!) ate the newline after the regexp.

We should just disable word wrapping in processes run by self-test
instead.
2015-03-09 22:31:49 -07:00
David Glasser
adc6d9969c Revert "Add some helpers for testing wrapped text"
This reverts commit 4a6dd52bca.

This made some tests flaky because notSpaceSensitive sometimes (but not
always!) ate the newline after the regexp.

We should just disable word wrapping in processes run by self-test
instead.
2015-03-09 22:30:44 -07:00
David Glasser
0a1dcee43c Show pattern for junk-before too 2015-03-09 22:13:07 -07:00
David Glasser
82e02c4cc4 test: Prevent overlapping meteor calls
They crashed sometimes, because meteor does that.
2015-03-09 18:51:40 -07:00
ekatek
50534fa252 fixing a test
The test is fine, but we were publishing a different version than we checked for.
(That is, we published 1.1.0, and were surprised when 1.0.1 did not show up).
Fixed.
2015-03-09 16:18:45 -07:00
David Glasser
b21aac4c72 fix spacing in deferred reg message 2015-03-09 15:39:22 -07:00
Slava Kim
eb33978b60 Always guard leaking env variables on Windows with SETLOCAL/ENDOCAL
Windows-only
2015-03-09 12:05:02 -07:00