Commit Graph

9 Commits

Author SHA1 Message Date
Felix Rabe
3431c66c16 Fix occurrences of "cd dirname $0"
They are not safe for spaces in paths. There might be other places to look for trouble.

I've run the following command to produce this commit: (on OS X, copy-and-pasting the below exactly)

    find . -type f -name '*.sh' -print0  |  # Find all .sh files
        xargs -0 fgrep -H -- '`'         |  # See all places with backticks in them
        fgrep 'cd `dirname $0'           |  # I deemed these problematic (variable assignments are safe)
        cut -d ':' -f 1                  |  # Take the <file> from <file>:<line> produced by "grep -H"
        tr '\n' '\0'                     |  # Also here, spaces can be problematic - always do "xargs -0"!
        xargs -0 -- sed -i '' 's/cd `dirname $0`/cd "`dirname "$0"`"/g'

The significance of adding the two levels of "'s can be verified by running the following in your Terminal:

    $ node -e 'console.log(process.argv.splice(1))' -- `echo 1   2`
    [ '1', '2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo 1   2`"
    [ '1 2' ]

    $ node -e 'console.log(process.argv.splice(1))' -- "`echo "1   2"`"
    [ '1   2' ]
2014-05-07 17:51:09 -07:00
David Glasser
1d9c2443e8 Automatically remove deprecated preserve-inputs 2014-03-26 15:02:34 -07:00
David Glasser
9fba51960c Clean up arch name in buildinfo when generating hashes.
Publish release manifests separately by platform and check they are the same in
publish-release.
2013-07-30 19:43:40 -07:00
David Glasser
e3c18578e3 Call upgraders at "meteor update" time.
Add "app-packages" to the list of upgraders in a release JSON.
2013-07-29 10:57:06 -07:00
David Glasser
bb9e78f562 fix shell script 2013-04-03 21:16:23 -07:00
David Glasser
643f5fac05 Ensure that tarballs do not contain hard links.
Make whitespace changes to tools and mongo-livedata so that we will build new
package versions with non-hard-linked Node plugins.
2013-04-03 21:14:25 -07:00
David Glasser
5c366a34fe build arch-specific packages, which contain NPM modules! 2013-03-29 11:52:33 -07:00
David Glasser
0825b3d7a2 don't call a release.json manifest.json ever, that's just confusing. 2013-03-19 18:19:56 -07:00
David Glasser
8a79edb43b "tools" -> "scripts", "engine" -> "tools" 2013-03-19 18:19:31 -07:00