Commit Graph

18 Commits

Author SHA1 Message Date
Avital Oliver
3ff6df2e9e Merge branch 'master' into devel
Conflicts:
	History.md
	packages/accounts-github/github_server.js
2013-04-24 14:01:22 -07:00
Avital Oliver
29ddfc6f3c accounts-github: Also send user agent on oauth login call 2013-04-24 10:46:44 -07:00
Avital Oliver
0bb71ff871 accounts-github: Generate user agent string from release version 2013-04-24 10:34:05 -07:00
P. Mark Anderson
2ffb185e47 Added user agent to account-github's getIdentity() function. This is untested.
See https://github.com/meteor/meteor/issues/981
2013-04-24 10:33:51 -07:00
Avital Oliver
cd6427fa5c Merge branch 'pr/982' into devel
Conflicts:
	packages/accounts-github/github_server.js
2013-04-24 10:00:24 -07:00
Avital Oliver
e43c94ee2e accounts-github: Generate user agent string from release version 2013-04-24 09:56:02 -07:00
P. Mark Anderson
b4d96d5795 Added user agent to account-github's getIdentity() function. This is untested.
See https://github.com/meteor/meteor/issues/981
2013-04-24 09:44:38 -07:00
Avital Oliver
f6028b1578 OAuth login services use the new http sync api 2013-04-22 15:40:04 -07:00
Avital Oliver
a72134fd80 Better security, comments, docs and APIs for publishing more user document fields 2013-04-19 11:38:09 -07:00
Avital Oliver
b6282eadd9 Publish user's login service fields in case autopublish is on.
Publish all but secret fields to the current user, and
basic identification information for other users.
2013-04-19 11:38:09 -07:00
Avital Oliver
a9272a6cbf Significantly improve error with misconfigured OAuth services
- We now rethrow any errors, which means we get a proper stack trace,
  rather than it seemingly coming from within a callback in the http package
- The error thrown contains the response body which typically contains
  helpful information
2013-04-13 20:16:28 -07:00
David Glasser
5a5204e3a4 Remove closures around package files. (hint: git blame -w)
The bundler now adds closures around client files and the server adds closures
around server files.
2013-03-19 15:13:53 -07:00
David Glasser
00eda43420 OAuth login to an existing account now *does* update the services.PROVIDER
field (eg, to refresh access tokens) but does *not* update anything else (which
is effectively a no-op change because in practice the only thing that it
attempted to update was "profile" but because existing fields were not
overridden, this never did anything).

Remove the "extra" argument from createUser and related functions. Add a new
"profile" option to the main options dictionary, interpreted by
defaultCreateUserHook.
2012-10-10 21:55:02 -07:00
David Glasser
dd77a26acc Rename Accounts.configuration to Accounts.loginServiceConfiguration.
Matches other references to it in the code, and is harder to confuse with
Accounts.config.
2012-10-09 19:18:02 -07:00
David Glasser
7b758a0c9b Rename and refactor Accounts.updateOrCreateUser.
This is an internal function only used by OAuth implementations and the
equivalent, so rename to a more specific name:
Accounts.updateOrCreateUserFromExternalService.

Change the signature to directly take serviceName and serviceData instead of a
nested data structure with a very specific structure. Similarly, change
Accounts.oauth.registerService's handleOauthRequest callback to un-nest the
service data.

Throw errors on misuse (if you try to use it with the "password" or
soon-to-be-introduced "resume" services, or if you don't provide an id).

Avoid doing no-op user updates if there is nothing new in "extra".
2012-10-08 09:18:55 -07:00
Avital Oliver
c086ca0912 accounts-github: cleanup, small tweaks 2012-10-05 00:22:09 -07:00
Braden Simpson
6da4833885 added username to the identity. 2012-09-27 11:19:10 -07:00
Braden Simpson
55e291e671 Added the accounts-github files into the main meteor repo 2012-09-24 19:57:06 -07:00