Commit Graph

51 Commits

Author SHA1 Message Date
David Greenspan
d064d744a3 Display progress when restarting the server
Previously, all progress display was turned off after the app’s initial start, so no progress would be displayed on restart due to server code change.

Now, we enable/disable progress display from inside the loop that re-runs the app on change.

Remove the “suppressDisplay” approach to hiding the spinner when there’s an error building the app, because it didn’t work on rebuilds, only the first build.  Better to just call enableProgressDisplay(false) and hope for the best like we do elsewhere.

Conflicts:
	tools/progress.js
2014-10-22 13:37:08 -07:00
Nick Martin
5eedfe8baf Disable color by default. 2014-10-22 11:10:11 -07:00
Emily Stark
11471a82c8 Supress progress spinner while waiting for file changes.
This prevents "Starting your app..." from showing immediately after
"Your app is crashing. Waiting for file changes."
2014-10-22 10:31:17 -07:00
Justin SB
5663d9efac Change progress message indent to 3, so it lines up with '=> Started ...' 2014-10-21 12:57:37 -07:00
Justin SB
828bd57004 Exit the status poller cleanly, so we never block process exit 2014-10-17 18:02:14 -07:00
Justin SB
78ae5012a1 Include the indent in the space-allocation calculation 2014-10-17 11:27:18 -07:00
Justin SB
fc8ecc53d3 Document the heuristic logic with some comments 2014-10-17 11:27:18 -07:00
Justin SB
c325023f15 Tweak when tasks are marked as done & current, also nudge the spinner when no progress 2014-10-17 11:27:17 -07:00
Justin SB
61cc351b95 Cleanups from self-code review 2014-10-17 11:27:17 -07:00
Justin SB
1b105953dd Don't bother with stop() function, just call depaint() directly 2014-10-17 11:27:17 -07:00
Justin SB
a68a12dd02 Replace the progress npm dependency with our own version
More or less copied code, for now (MIT licensed)
2014-10-17 11:27:17 -07:00
Justin SB
301357674f A few notes on what we need to do fully remove Patience 2014-10-17 11:27:16 -07:00
Justin SB
2f86bdf406 Move patience to console 2014-10-17 11:27:16 -07:00
Justin SB
e8477f3a2c Fix a large number of small mistakes 2014-10-17 11:27:15 -07:00
Justin SB
c24859de70 Advance spinner at constant speed 2014-10-17 11:27:15 -07:00
Justin SB
e279a442f4 Initialize _fraction 2014-10-17 11:27:14 -07:00
Justin SB
ecd1e19bb9 Create repaint / depaint 2014-10-17 11:27:14 -07:00
Justin SB
2381e22906 Support spinner if progress fraction is unknown 2014-10-17 11:27:14 -07:00
Justin SB
8436ee6a5d Move constants higher in console.js 2014-10-17 11:27:14 -07:00
Justin SB
d1fdb06103 Add yield to Console.nudge(), remove old exponential nudge which didn't look right 2014-10-17 11:27:13 -07:00
Justin SB
e02c254eab Delete dead function 2014-10-17 11:27:13 -07:00
Justin SB
5562865287 Rename Console.statusPollMaybe -> Console.nudge
We're working towards replacing patience
2014-10-17 11:27:13 -07:00
Justin SB
089eab6792 Refactor console to separate out progress/status display 2014-10-17 11:27:12 -07:00
Justin SB
ee5e99d406 Prettier meteor show 2014-10-17 07:15:20 -07:00
Justin SB
a3be9a0ac6 Make meteor search output prettier 2014-10-17 06:26:47 -07:00
Justin SB
9c3e29c663 Log changed env vars for commands we run
This is particularly useful for Android, where we pass ANDROID_SDK_HOME
2014-10-15 14:22:44 -07:00
Avital Oliver
5af5a98342 Hide springboard progress bar when complete
Fixes https://app.asana.com/0/802778796897/17391461309554

Apparently Console.enableProgressBar is written to do nothing if Console
is not in pretty mode.
2014-10-09 11:46:05 -07:00
Justin SB
88a836383b Embolden commands users should run 2014-10-06 14:04:20 -07:00
Justin SB
6307ace605 Start android emulator earlier in the run process 2014-10-03 15:28:00 -07:00
David Greenspan
9922283515 Disable progress bar when prompting
Can’t tell for sure if it works, but it ought to
2014-10-03 14:51:22 -07:00
Justin SB
c50bdca142 Check platform readiness on run & print errors appropriately 2014-10-03 08:07:45 -07:00
Justin SB
90a24c9bd8 Check for meteor avd 2014-10-01 15:18:38 -07:00
Justin SB
6be55e61bf Creating android --getready command 2014-10-01 14:42:30 -07:00
ekatek
c67de0830a merging from sqllite 2014-09-30 16:29:41 -07:00
David Greenspan
6a35e05ba3 Clear status message on enableProgressBar(false)
Motivated by `meteor shell` in Emacs shell-mode
2014-09-30 11:51:17 -07:00
David Greenspan
5e39040e41 Fix “status message mode”
It has to wait for _pretty to become true so that it doesn’t start displaying statuses too soon.

There are now explicitly three modes, one where _progressBar is defined, one where it isn’t but _inStatusMessageMode is true, and one where neither is truthy.
2014-09-29 16:49:07 -07:00
David Greenspan
df6f93186b Print status messages even without progress bar
For example, in emacs shell, which is not a real TTY.
2014-09-29 16:18:38 -07:00
David Greenspan
1cf9eef9d0 Detect Emacs’s pseudo-TTY and don’t progress bar 2014-09-29 16:18:38 -07:00
David Greenspan
aa91cc4e6b Reduce progress bar polling (and make a constant) 2014-09-29 16:18:38 -07:00
Justin SB
043a0b8f3f Format all arguments to Console.X, just like console.log 2014-09-29 09:08:00 -07:00
Justin SB
6d5884ebca Cleaner logging; introduce Console.debug & METEOR_LOG=debug 2014-09-29 08:59:07 -07:00
ekatek
dd7635af6e merging from master 2014-09-25 19:45:48 -07:00
Justin SB
0c35bff3e2 Minimal fix for progress bar preventing 'meteor mongo' from exiting 2014-09-23 10:58:40 -07:00
Justin SB
b1e6a2a0ae Cleanup Console code, and make sure we cleanup the poller on exit
Not cleaning up the poller was preventing 'meteor mongo' from exiting cleanly
2014-09-23 05:40:29 -07:00
Justin SB
9c5abcc8fa Use cleanup onExit instead of process.on('exit', ) 2014-09-19 19:53:16 -07:00
Justin SB
27a1a66039 Make sure the progress bar is hidden when we exit the process
Otherwise it leaves artifacts when we call process.exit
2014-09-19 19:49:23 -07:00
Justin SB
30442946cf Set warning as an alias for warn on Console.prototype, not on the singleton 2014-09-19 18:42:47 -07:00
Justin SB
3b84a63fc2 Choose stdout/stderr, even if we're not in pretty mode 2014-09-19 18:04:06 -07:00
Justin SB
db11a5de0b Use pretty on a per-command basis
It can be overridden using METEOR_PRETTY_OUTPUT=0 or METEOR_PRETTY_OUTPUT=1
2014-09-19 16:56:25 -07:00
Justin SB
5abc41222c Hide progress bar when we're not watching any tasks 2014-09-19 16:56:25 -07:00