Commit Graph

304 Commits

Author SHA1 Message Date
Ben Newman
33e4a6e658 Bump package versions for 1.4.3-rc.1 release. 2017-02-07 15:36:12 -05:00
Ben Newman
9502f1bd79 Bump package versions for 1.4.3-rc.0 release. 2017-02-02 17:19:07 -05:00
Jesse Rosenberger
f33f75d759 Bump package versions for 1.4.3-beta.3 release. 2017-01-26 16:12:26 -08:00
dr-dimitru
edf58bc8cc PR review changes 2017-01-17 20:54:33 +03:00
dr-dimitru
ebde43db67 Changes as requested + JavaScript Style Guide rules
- Apply rule [#16.1](https://github.com/meteor/javascript#16.1) to
if/else blocks
2017-01-17 14:02:12 +03:00
dr-dimitru
5b193e53b4 More linting
- Line 88: `selector` variable defined but never used
 - Apply rule [#16.1](https://github.com/meteor/javascript#16.1) to
if/else blocks
2017-01-17 13:58:02 +03:00
dr-dimitru
2a8667d529 Fiver packages is not used 2017-01-17 13:50:49 +03:00
dr-dimitru
fc3349b451 Changes as requested 2017-01-17 13:50:31 +03:00
dr-dimitru
ada34ef3ce Requested changes + JavaScript Style Guide rules
- Changes according to PR request
 - Apply rule [#16.1](https://github.com/meteor/javascript#16.1) to
if/else blocks
2017-01-17 13:48:32 +03:00
dr-dimitru
a60b30f64e Requested changes + apply some JavaScript Style Guide rules
- Changes according to PR request
 - Apply rule [#16.1](https://github.com/meteor/javascript#16.1) to
if/else blocks
2017-01-17 12:34:11 +03:00
dr-dimitru
3739a602d2 Fiber lib is not used at mongo_driver.js file 2017-01-17 12:10:27 +03:00
dr-dimitru
bd61f6b421 Changes according to PR request 2017-01-17 12:09:55 +03:00
dr-dimitru
23b55647d2 Variable used about of scope
- `newResults` defined inside try, and used in parent scope later
2016-12-21 03:25:33 +03:00
dr-dimitru
92a2c4f98b Variable used out of scope
- `lastEntry` defined on while loop (line 139), and used later at
parent scope
2016-12-21 03:23:06 +03:00
dr-dimitru
7a8ce9a75e Fix misleading lines and variable scope
- Line 425 and 448: `maxBuffered` is defined twice in same scope
(hoisting)
2016-12-21 03:21:25 +03:00
dr-dimitru
4197c9d99e Add missing semicolons, fix variables scope
- Lines 481 - 498: `val` and `x` is defined twice (hoisting)
 - Lines 973 - 975 and 980 - 982: `expectedRemoves` and `expectedAdds`
is defined on lines 952 and 955
2016-12-21 03:20:17 +03:00
dr-dimitru
1472a41a16 Add missed semicolons, one-line misleading lines 2016-12-21 03:16:48 +03:00
dr-dimitru
fa631c4101 Missed semicolons 2016-12-21 03:02:00 +03:00
dr-dimitru
a71a6e6cd9 Overall listing, missed semicolons 2016-12-21 03:01:30 +03:00
dr-dimitru
cea6f4a806 No need to set variable to undefined 2016-12-21 02:57:04 +03:00
dr-dimitru
349a1b48fc beta version bump 2016-12-21 02:55:14 +03:00
dr-dimitru
69ef77bcb6 - Lines 66, 1011 and 1352: Linting
- Line 497: `return` after `throw`
- Lines 523 - 527: `e` already defined in same function scope
(hoisting)
- Line 937: Missed semicolon
- Line 1095: Very confused about ES6 “default parameter” set via
colon, which probably will be interpreted as Object - Babel failed to
build on my end, regarding [this
docs](https://mongodb.github.io/node-mongodb-native/api-generated/cursor
.html#count) it should be a Boolean, so we set it to `false` by default
- Line 1120: no need to set variable to `undefined`
- Lines 1122, 1128, and 1133: Define `doc` above while due to function
scope and hoisting `doc` is already allocated inside `while` and `try`
2016-12-21 02:55:02 +03:00
David Glasser
8a81e7156e Fix missing var in mongo package. 2016-12-19 11:43:14 -08:00
Ben Newman
ba5c8ff530 Bump package versions for 1.4.3-beta.1 release. 2016-12-06 10:18:45 -05:00
Ben Newman
9ee7e46be9 Bump package versions for 1.4.3-beta.0 release. 2016-12-01 16:44:48 -05:00
Ben Newman
f39812bd4b Bump package versions for the official 1.4.2 release. 2016-10-25 10:20:21 -07:00
Ben Newman
b40df12129 Bump package versions for 1.4.2-rc.4 release. 2016-10-24 22:44:11 -07:00
Ben Newman
dbf8471c1f Bump package versions for 1.4.2-rc.3 release. 2016-10-23 18:17:51 -04:00
Ben Newman
b938e089e6 Bump package versions for 1.4.2-rc.2 release. 2016-10-21 22:20:34 -04:00
Ben Newman
0308e38d51 Merge branch 'release-1.4.1.3' into release-1.4.2 2016-10-21 22:03:54 -04:00
Ben Newman
f419899ce7 Bump package versions for the official 1.4.1.3 release. 2016-10-21 20:15:28 -04:00
Ben Newman
247fa7b8ae Bump package versions for 1.4.1.3-rc.1 release. 2016-10-21 12:38:09 -04:00
Christian Klaussner
f9b0f2f60d Update links to MongoDB driver docs 2016-10-21 11:25:18 -04:00
Ben Newman
5d3e2bd884 Bump mongo package version to 1.1.12_5. 2016-10-21 11:12:54 -04:00
Ben Newman
0344f58b06 Set mongoOptions.server.reconnectTries = Infinity.
Setting mongoOptions.server.auto_reconnect was removed by #7880 via commit
0ffb9ac824, though it seems the Server
options still respect autoReconnect, even in version 2.2 of the driver:
http://mongodb.github.io/node-mongodb-native/2.2/api/Server.html

That said, having inspected the code of the `mongodb` package, I do not
believe this change is really critical, since the default value for
autoReconnect appears to be true.

More importantly, I can't find any support in the code of the `mongodb`
npm package or its dependencies for the claim that setting
mongoOptions.server.reconnectTries to 0 is the same as making it infinite,
so this commit sets it to Infinity.
2016-10-21 11:12:54 -04:00
Ben Newman
037e9b8820 Use npm-mongo@2.2.10_1 in mongo@1.1.12_4. 2016-10-21 11:12:54 -04:00
Tom Coleman
554eb628eb Reconnect to mongo indefinitely. (#7880)
* Reconnect to mongo indefinitely.

A fix for https://github.com/meteor/meteor/issues/7822

It seems the driver now always autoReconnects, but only for 30s.

To get the old (sensible) behavior of endlessly reconnecting, we set `reconnectTries` to 0.

* Releasing an rc of mongo package
2016-10-21 11:12:53 -04:00
Ben Newman
04056db28f Bump package versions for 1.4.2-rc.1 release. 2016-10-19 18:12:27 -04:00
Ben Newman
8142521610 Merge pull request #7935 from klaussner/mongodb-driver-links
Update links to MongoDB driver docs.
2016-10-18 16:49:37 -04:00
Christian Klaussner
a171938daf Update links to MongoDB driver docs 2016-10-18 22:31:45 +02:00
Ben Newman
ccd960eeb3 Bump package versions for 1.4.2-rc.0 release. 2016-10-18 14:32:13 -04:00
Ben Newman
1ac4bbaa84 Bump package versions for 1.4.2-beta.13 release. 2016-10-17 11:51:55 -04:00
Ben Newman
168351c472 Bump package versions for 1.4.2-beta.12 release. 2016-10-14 16:47:59 -04:00
Ben Newman
f42ca04fdb Bump package versions for 1.4.2-beta.11 release. 2016-10-13 21:46:35 -04:00
Ben Newman
0c324f3145 Bump mongo package version to 1.1.12_5. 2016-10-08 14:58:45 -04:00
Ben Newman
3ee0cd73e1 Set mongoOptions.server.reconnectTries = Infinity.
Setting mongoOptions.server.auto_reconnect was removed by #7880 via commit
0ffb9ac824, though it seems the Server
options still respect autoReconnect, even in version 2.2 of the driver:
http://mongodb.github.io/node-mongodb-native/2.2/api/Server.html

That said, having inspected the code of the `mongodb` package, I do not
believe this change is really critical, since the default value for
autoReconnect appears to be true.

More importantly, I can't find any support in the code of the `mongodb`
npm package or its dependencies for the claim that setting
mongoOptions.server.reconnectTries to 0 is the same as making it infinite,
so this commit sets it to Infinity.
2016-10-08 14:53:24 -04:00
Ben Newman
cc5bb86611 Use npm-mongo@2.2.10_1 in mongo@1.1.12_4. 2016-10-08 13:58:37 -04:00
Ben Newman
d8d70eaba6 Revert "Add version constraints to dependencies of the mongo package."
This (partially) reverts commit 904c77fe80.
2016-10-07 16:41:45 -04:00
Ben Newman
904c77fe80 Add version constraints to dependencies of the mongo package. 2016-10-07 16:02:07 -04:00
Tom Coleman
0ffb9ac824 Reconnect to mongo indefinitely. (#7880)
* Reconnect to mongo indefinitely.

A fix for https://github.com/meteor/meteor/issues/7822

It seems the driver now always autoReconnects, but only for 30s.

To get the old (sensible) behavior of endlessly reconnecting, we set `reconnectTries` to 0.

* Releasing an rc of mongo package
2016-10-07 15:47:35 -04:00