Commit Graph

22356 Commits

Author SHA1 Message Date
Geoff Schmidt
9b3cd467d0 Second draft of observe/observeChange docs 2013-02-07 15:41:20 -08:00
Geoff Schmidt
557dd363f4 markdown is mia 2013-02-07 14:52:18 -08:00
Geoff Schmidt
97cbc5a50e correct error in previous commit 2013-02-07 13:49:10 -08:00
Geoff Schmidt
e2ddf0aead Change descriptions of observe and observeChanges 2013-02-07 13:47:52 -08:00
David Glasser
62bcab56d1 Merge branch 'devel' into ddp-pre1 2013-02-07 10:47:06 -08:00
Nick Martin
66c94bfed6 Merge branch 'pr-651' into devel 2013-02-06 19:39:47 -08:00
Nick Martin
38c5795c71 Review from Geoff 2013-02-06 19:39:31 -08:00
Nick Martin
68049c276d Move tests from handlebars to templating, as they depend on templates. Also, extend to test a few more types. 2013-02-06 19:39:31 -08:00
Nick Martin
719f2e10dc Use regexp instead of isNaN for detecting integers. 2013-02-06 19:39:31 -08:00
Morten Henriksen
7ca41e4a3c Added fix, workaround handlebars issue and added tests 2013-02-06 19:39:31 -08:00
Naomi Seyfer
515b04f13c Example publish now uses observeChanges 2013-02-06 18:39:57 -08:00
Naomi Seyfer
c6f72b612f Draft docs for new observe 2013-02-06 18:37:33 -08:00
Naomi Seyfer
747a6ce20c Following through on allowing you to mix callbacks styles within reason 2013-02-06 16:17:53 -08:00
Naomi Seyfer
2abce8caf8 greenspan-recommended additions to OrderedDict api 2013-02-06 14:39:40 -08:00
David Glasser
d1de04dbea Explicitly make {$regexp: "foo", $options: "garbage"} throw.
This check was explicitly in the old selector compiler but the rewrite dropped
it. The `new RegExp("foo", "garbage")` throws on most browsers but not on old
WebKit.
2013-02-06 14:25:22 -08:00
Naomi Seyfer
38db5ddc1d * remove spark dependency on minimongo * simpler to use orderedDict with obj k
Removed spark dependency on minimongo by duplicating a very small amount of
code.  There is an XXX to mark it.

OrderedDict can have a function as the first argument to its constructor; it
will use the function to transform whatever object is used as a key to strings.
2013-02-06 14:23:47 -08:00
David Glasser
de6a08d09e Choose an even more portable CSS property to test @imports.
Colors were showing up as rgb(a, b, c) in some browsers and as #aabbcc in
others.
2013-02-06 14:08:39 -08:00
Matt DeBergalis
6e645071dc tweaks 2013-02-06 11:50:35 -08:00
Nick Martin
64d1361cf9 First draft contributing file. Basically just copied from the wiki.
Once this is released to master, we should update the wiki to point to it.
2013-02-05 22:27:26 -08:00
David Glasser
453679da6e Merge branch 'dev-bundle-less-upgrade' into devel 2013-02-05 18:35:33 -08:00
David Glasser
05ac3ad75d Document how to prevent your less imports from being double-processed. 2013-02-05 18:34:55 -08:00
David Glasser
adcae951eb Switch less back to fully synchronous, now that the NPM module supports it.
syncImport was added in 1.3.2 and we just upgraded from 1.3.1 to 1.3.3.

Otherwise error handling gets pretty fussy (eg, sometimes less throws from
within a callback).
2013-02-05 18:11:59 -08:00
David Glasser
6f8516d36b Upgrade less to 1.3.3.
Should improve the error message in https://github.com/meteor/meteor/issues/203
(see https://github.com/cloudhead/less.js/issues/990) though it may not fix the
way that the error is handled.
2013-02-05 17:15:04 -08:00
Naomi Seyfer
18d4a6ea4b Remove undefined from EJSON 2013-02-05 16:57:26 -08:00
David Glasser
19868587fc Update comments and internal function name in mongo_driver. 2013-02-05 16:42:18 -08:00
David Glasser
b8c4486653 Move EJSON.addType("oid") to the ObjectID class's declaration. 2013-02-05 16:36:40 -08:00
David Glasser
25fa54cbae Meteor.Error will not be encoded in EJSON. We are relying on how it encodes as
EJSON already. Make this clear.
2013-02-05 16:36:39 -08:00
Naomi Seyfer
0077bbbb65 Refactoring ordered_dict to reuse linked-list code 2013-02-05 16:27:59 -08:00
David Glasser
d62c8b53a4 Merge branch 'devel' into ddp-pre1
Conflicts:
	packages/livedata/livedata_connection_tests.js
          (needed to fix new test to work with new DDP messages)
2013-02-05 16:16:11 -08:00
Naomi Seyfer
d3d267d95b Deleted dead code from wordplay 2013-02-05 16:15:51 -08:00
David Glasser
5177e0ba1f Don't drop quiescence state on initial connect.
We may have already run a stub before getting 'connected'! (Wordplay does this.)

(The same fix, without test, was already committed to ddp-pre1.)
2013-02-05 16:12:24 -08:00
Naomi Seyfer
2c9017f162 Remove suppression check from observe converters; rename them.
At Glasser's urging
2013-02-05 16:09:38 -08:00
David Glasser
656e74d657 Don't drop quiescence state on initial connect.
We may have already run a stub before getting 'connected'! (Wordplay does this.)
2013-02-05 15:52:02 -08:00
Nick Martin
02ae0734d0 Upgrade jquery-layout to 1.3.0RC. The jquery-latest site recommends it over 1.2.0 despite the RC designation. Fixes #556. 2013-02-05 15:37:52 -08:00
Naomi Seyfer
8b737a7e39 Finish switching over to new observe API in core packages and tests. 2013-02-05 14:26:32 -08:00
David Glasser
cde1f010ae Remove old XXX comment about $elemMatch needing tests. 2013-02-05 12:07:48 -08:00
David Glasser
dd459e10a3 Improve a test (now that its comment is inaccurate). 2013-02-04 18:18:40 -08:00
David Glasser
c476668110 Merge branch 'ddp-pre1-selector-compiler-rewrite' into ddp-pre1
Incorportate the selector compiler rewrite (from devel), making necessary
adjustments based on ddp-pre1's changes.
2013-02-04 18:17:29 -08:00
David Glasser
55a90e1a70 Adapt selector-compiler to ddp-pre1.
Make sure that direct ID comparisons use EJSON.equals.

Now all tests pass.
2013-02-04 18:13:50 -08:00
Tim Haines
a067818553 Adjust accounts-twitter to use Twitter's id_str instead of id 2013-02-04 18:11:03 -08:00
David Glasser
4c2bc76c7e EJSON: Remove serializeForEval method, no longer needed with new selector
compiler.
2013-02-04 17:47:06 -08:00
David Glasser
eaff6f3b00 Merge branch 'devel' into ddp-pre1-selector-compiler-rewrite
Note: some tests fail. Will be resolved before merging to ddp-pre1.

Conflicts:
	packages/minimongo/selector.js
2013-02-04 17:46:22 -08:00
Naomi Seyfer
1ca1f565d1 Partially change observe API to new one
Code now calls addedAt, etc. on ordered observes.
Not yet changed to autodetect observe orderedness by method names.

Tests pass.  Have not changed examples yet, nor docs.
2013-02-04 17:03:29 -08:00
David Glasser
baceda9d65 Merge branch 'selector-compiler-rewrite' into devel
This is a complete rewrite of the Minimongo selector and sort compiler to no
longer use eval, started by @Ed-von-Schleck and finished by @glasser. It makes
the code more readable and no longer requires all queryable types to be
serializable in an eval-able way; the latter will be useful once the in-process
EJSON work on the ddp-pre1 branch is ready.

(It also makes selector compilation faster, though selector evaluation appears
to be very slightly slower.)
2013-02-04 16:42:47 -08:00
David Glasser
3bdf41add1 Rewrite sort compiler to avoid eval, too! 2013-02-04 16:42:18 -08:00
jperl
b24317b3ef Return all basic google and facebook profile fields 2013-02-04 19:23:11 -05:00
Naomi Seyfer
a866689c6a Escaping in EJSON only goes one level 2013-02-04 16:12:49 -08:00
Naomi Seyfer
d92628020f Refactor Spark to use observeChanges instead of observe
It uses an orderedDict instead of an array, and also this new version happens to
not do a ton of splices, which might help with performance in cases for really
large numbers of items.  Anyway, introduced a dependency on LocalCollection;
will break that soon.
2013-02-04 14:42:45 -08:00
David Glasser
0567a730b1 Rewrite selector compiler against with a "compile to specific function"
approach.
2013-02-04 14:32:12 -08:00
David Glasser
2692192547 Some modifications to Ed-von-Schleck's selector compiler patch:
- Improve regex match against array.
- Improve matching of explicit deep nulls.
- Instead of doing a high-level "catch TypeError", do more explicit
  type checks.
- Clone the selector (since we're going to save a reference in our
  closure).
2013-02-04 14:32:12 -08:00