Commit Graph

4379 Commits

Author SHA1 Message Date
Avital Oliver
358d797373 Improve error on publish-for-arch with colons
It's unfortunate that this change is in `compiler.compile`. It's
actually unfortunate that we only catch this during publish-for-arch.
But it seems too much to disallow all packages published with colons
even if they don't have binary dependencies since a lot of old
packages were created with our command-line tool that created
filenames with colons in them.
2015-03-26 18:46:12 -07:00
David Glasser
d79ca97398 Be clearer that you need to publish for this arch
Fixes #3961.
2015-03-26 17:32:37 -07:00
Avital Oliver
120febbf8a Fix meteor reset on Windows
We were incorrectly always assuming that Meteor is running
by not actually trying to connect to the port that the
MONGO-PORT file reports Mongo is listening to.

The problem is that that file isn't cleared when Meteor
quits or crashes.

Fixes https://github.com/meteor/windows-preview/issues/138
2015-03-26 17:11:17 -07:00
Slava Kim
2b2b721ff4 Reformat the warnings 2015-03-26 17:07:00 -07:00
Slava Kim
0a7cf60294 Add a warning about proxy env variables when a connection in tool fails 2015-03-26 16:58:41 -07:00
Slava Kim
ac15655897 Remove stray if statemet
A leftover from debugging
2015-03-25 18:25:04 -07:00
Slava Kim
9305e9d514 Adapt wipe-all-packages command to Windows layout 2015-03-25 17:16:46 -07:00
Slava Kim
a1fefa9f92 Fix wipe-all-packages test for Windows 2015-03-25 17:16:46 -07:00
Slava Kim
7e03f78b80 Be able to parse absolute and relative paths in meteor.bat 2015-03-25 17:16:46 -07:00
Slava Kim
9b12a33c6b Fix the default release track issue on Windows 2015-03-25 17:16:46 -07:00
Slava Kim
bba6b617a3 Add fake builds in the test 2015-03-25 17:16:46 -07:00
Slava Kim
5337b3b6c6 Fix the test to generate a relative symlink 2015-03-25 17:16:46 -07:00
Slava Kim
d9cc95531b additional checks in tests to ensure that exactly two versions of tool are not removed 2015-03-25 17:16:46 -07:00
Slava Kim
7be6fe4018 Wipe all packages test
Tested on Mac
2015-03-25 17:16:46 -07:00
Sashko Stubailo
0e3e529751 Add command to test wipeAllPackages 2015-03-25 17:16:46 -07:00
Sashko Stubailo
4ff636c7df Merge branch 'master' into release-1.1
Conflicts:
	History.md
2015-03-25 16:07:42 -07:00
David Greenspan
e97e29e8b0 Add --allow-incompatible-update to more commands
In particular: `create`, `test-packages`, `rebuild`, `publish`, 
`publish-for-arch`, `admin run-upgrader`

Add it to the help text for `publish`, and simply force the flag to
true in `create`.  Other commands get it as an undocumented flag
in case the version solver tells you to pass it in.
2015-03-25 14:30:59 -07:00
sashko
3a748a5ab6 Remove unlinking ssh code that fails
We delete temp directories anyway!
2015-03-24 21:37:30 -07:00
Slava Kim
fa593632f3 Expand on the comment being related to Windows 2015-03-24 17:29:08 -07:00
Slava Kim
fa6d536c80 Always set the path to the node binary when running npm from Meteor 2015-03-24 17:29:02 -07:00
Sashko Stubailo
f9906346db Remove WINDOWS-PREVIEW hack
So that there is a recommended release published for Windows

Conflicts:
	tools/utils.js
2015-03-24 17:21:59 -07:00
Sashko Stubailo
31d199124f Revert "Remove WINDOWS-PREVIEW hack"
This reverts commit 84c0b3ccd8.
2015-03-24 17:19:47 -07:00
Sashko Stubailo
84c0b3ccd8 Remove WINDOWS-PREVIEW hack
So that there is a recommended release published for Windows
2015-03-24 17:18:15 -07:00
Avital Oliver
79f7f162f1 Fix long file paths passed to files.createTarball
The fix is actually in https://github.com/npm/fstream/pull/42,
but now we also remove our explicit path length check
that used to throw an error instead of silently losing files.

This commit also adds a self-test to test the entire flow
through `files.createTarball` and `files.extractTarGz`.
2015-03-23 19:56:19 -07:00
David Glasser
ab2e629239 Upgrader for Facebook API change. 2015-03-23 14:57:54 -07:00
sashko
91be1eac7c Make admin get-machine link to SSH directions 2015-03-23 14:18:09 -07:00
Slava Kim
ccc98c1838 Always exit with the same exit code as Meteor node script, in warehouse 2015-03-23 12:14:11 -07:00
Slava Kim
5dc8ea5ffb Always convert \r\n and \r sequences to \n on file reading in tool
Fixes https://github.com/meteor/windows-preview/issues/104
2015-03-20 17:35:55 -07:00
Slava Kim
d8e22d9404 Consistently parse end-of-line characters as "\n" on all platforms for the meteor shell history file.
Fixes the bug where the history would be parsed as one big blob on Windows,
because it is always written with "\n" but parsed with "\r\n" on Windows and
"\n" on Unixy platforms.
2015-03-20 17:00:34 -07:00
Slava Kim
ca82e5f956 Read file as utf8
So the return value is a string and not a buffer
2015-03-20 15:12:45 -07:00
Slava Kim
155375da1f Always try to read the mongo port file on Windows 2015-03-20 15:03:28 -07:00
Sashko Stubailo
b1d0c1c93e Improve message when no build found 2015-03-20 14:38:25 -07:00
David Glasser
aa2867b3ea Clean up Cordova app IDs a bit
Starting with cordova-lib 4.2.0 (shipped with Meteor 1.0.4) the cordova
create command checks that app IDs look like Java namespaces.  Clean up
the most obvious ways that our generated app IDs won't look like Java
namespaces (most notably hyphens).

This isn't perfect (eg we don't check for leading digits or
consecutive/leading/trailing dots, or for Java reserved words).  This
check is implemented by the valid-identifier NPM package.

While we're at it, put app ids under `com.meteor.userapps` so that there
are other parts of `com.meteor` available for potential MDG Java work.

Fixes #3950.
2015-03-20 11:11:44 -07:00
David Glasser
dabe0ae2f0 Clean up Cordova app IDs a bit
Starting with cordova-lib 4.2.0 (shipped with Meteor 1.0.4) the cordova
create command checks that app IDs look like Java namespaces.  Clean up
the most obvious ways that our generated app IDs won't look like Java
namespaces (most notably hyphens).

This isn't perfect (eg we don't check for leading digits or
consecutive/leading/trailing dots, or for Java reserved words).  This
check is implemented by the valid-identifier NPM package.

While we're at it, put app ids under `com.meteor.userapps` so that there
are other parts of `com.meteor` available for potential MDG Java work.

Fixes #3950.
2015-03-20 11:03:36 -07:00
Avital Oliver
e95cc58031 Fix publish-for-arch in Windows
We recently changed the package tarball structure to use
colonConverter in package-client.js but not in
commands-package.js
2015-03-18 00:26:38 -07:00
David Glasser
21bdac8734 Merge branch 'master' into devel
Conflicts:
	History.md
	packages/accounts-password/package.js
	packages/accounts-password/password_server.js
	packages/constraint-solver/package.js
	packages/meteor-tool/package.js
	packages/non-core/npm-bcrypt/package.js
	packages/package-version-parser/package-version-parser-tests.js
	packages/package-version-parser/package-version-parser.js
	packages/package-version-parser/package.js
	tools/selftest.js
2015-03-17 13:41:14 -07:00
David Glasser
8409919bb6 actually fail on package creation error 2015-03-17 12:14:16 -07:00
David Glasser
cfb21f43e5 Move third-party licenses into subdirectory
This should make them easier to update.
2015-03-17 11:18:57 -07:00
Sashko Stubailo
efdfe62331 Validate number of colons in package name on create
Instead of in the general package version parser
2015-03-17 10:56:33 -07:00
David Greenspan
269f32fec6 Fix package-tests: package specifying a name
a self-test broken by the version solver changes.
2015-03-16 16:18:02 -07:00
David Glasser
d591a288e1 Fix Android emulator access
Also fix odd use of `false` where everything else used `true`.
2015-03-13 18:49:30 -07:00
David Greenspan
6261fc2de7 Let meteor update --release downgrade packages
When the tool runs the constraint solver to see what releases can
be chosen, it creates its own ProjectContext and does not pass
command-line flags through.  Additionally, if the release you ask
for is not possible to choose for whatever reason (constraints in
.meteor/packages, and now the guard against downgrading root
dependencies), the error is swallowed and a pleasant "success"
message is printed.  We should probably fix this at some point.

For now, `meteor update --release` just runs the constraint solver
as if `--allow-incompatible-update` was passed, which effectively
means it gets to ignore `.meteor/versions` if necessary.
2015-03-13 11:28:48 -07:00
David Greenspan
1b85b8205e Enable detailed profiling of the constraint solver
See the report using METEOR_PROFILE=1
2015-03-13 10:47:52 -07:00
Slava Kim
171e10a87f Create ssh files in a temp dir assigned by files.js
and not in /tmp
2015-03-12 22:59:28 -07:00
Slava Kim
6dede19a60 Clear screen before dropping into a Windows ssh 2015-03-12 22:46:58 -07:00
Avital Oliver
7b8748e11d Change result of meteor --version on Windows
It now actually prints the "WINDOWS-PREVIEW" track on which
it is released.
2015-03-12 21:09:14 -07:00
Avital Oliver
942db816ca Add windows arch to two lists 2015-03-12 19:49:24 -07:00
David Greenspan
83dc85478f Add "Select Package Versions" to METEOR_PROFILE
There's no detail yet, but I'm going to add some.  In the mean time,
you just get the total ms for "Selecting Package Versions...", and
if it runs a second time you'll get another report for "(Try 2)"!
2015-03-12 18:12:01 -07:00
Sashko Stubailo
c6ea68f9b3 Make meteor create --package not use prefix
It used to create a directory with an underscore instead of a colon
Now, it just removes the prefix.

In cases where the name of the package has more than one colon or starts or ends
witha colon, we report an error.
2015-03-12 17:57:27 -07:00
David Greenspan
a75b0a441a Remove dead code from profile.js 2015-03-12 17:21:30 -07:00