Commit Graph

6746 Commits

Author SHA1 Message Date
Ben Newman
fb080c1a83 Merge branch 'devel' into release-1.6.1 2017-11-24 11:38:19 -05:00
Hugh Willson
92bcfaef84 Add os.windows.x86_64 to meteor build --architecture help (#9413)
The `meteor build --architecture` help was missing
`os.windows.x86_64`. This commit adds it in and also updates
an out of date comment in the source that referred to there
only being 3 allowed architectures.
2017-11-24 11:35:42 -05:00
Ben Newman
26189d93b9 Avoid hiding the first line of get-machine deprecation notice.
As explained in the entry for the `meteor` command, the first line of each
entry in help.txt is the summary for autogenerated command lists, and thus
will not be displayed in the help for the command.
2017-11-22 15:35:24 -05:00
Ben Newman
a6b90f85c3 Merge branch 'devel' into release-1.6.1 2017-11-22 14:52:58 -05:00
Ben Newman
c8c88300a6 Fix remaining problems with PR #9237. 2017-11-22 14:44:22 -05:00
Edgar HIPP
16b74e5c0c Fix isNpmUrl to handle http/https urls (Closes #9236) 2017-11-22 14:44:22 -05:00
Ben Newman
6a312c49cd Guard against undefined process.env.NPM_CONFIG_REGISTRY.
https://github.com/meteor/meteor/pull/9398#discussion_r152610836
2017-11-22 13:12:37 -05:00
skirunman
1d5bf0f1a4 iPhone X status bar fix (#9375) 2017-11-22 11:36:45 -05:00
James Burgess
2547957268 Fix meteor test file matching patterns (#9339)
* Adjust test filename RegExps to match Meteor guide. Fixes #9332.
* Adjusted help text for --drive-package on meteor test.
* Add integration tests for `meteor test` eager file loading.
* Fix typo in selftest.forbid comment.
* Improve test file eager load integration test coverage and clarity.
2017-11-22 11:21:49 -05:00
Hugh Willson
8da6c84eac Update the default CSS parsing/combining/minifying tools (#9263)
* Update the default CSS parsing/combining/minifying tools

The `minifier-css` package is currently using outdated
(and abandoned) npm packages (`css-parse` and `css-stringify`),
as part of its parsing/minification process. This commit
replaces those packages with the robust, modern and maintained
`postcss` package.

* Adjust CSS source file fallback value

* Self test adjustments and cleanup

* Disable sourcesContent generation by postcss

The `standard-minifier-css` package is already associating
source content with the source map, so we don't need to
do this twice.

* Add History.md entry covering backwards compatibility details

* Bump major version due to backwards compatibility breaking changes

* Bump minor versions

* Code review changes (boolean formatting, concat to spread)
2017-11-22 11:13:54 -05:00
sebakerckhof
4ce2645fbf Add scoped packages to shrinkwrap 2017-11-20 17:57:19 +01:00
sebakerckhof
1bb46bc103 Don't use resolved urls as package version when using a private NPM server 2017-11-20 17:54:45 +01:00
Ben Newman
5bdf684525 Merge branch 'devel' into release-1.6.1 2017-11-17 14:34:11 -05:00
Jesse Rosenberger
2fee9e4d7f Change let to const for some nearby use cases. 2017-11-17 20:27:54 +02:00
Jesse Rosenberger
1ed7796956 Change nested imports to share related, top-level imports.
I believe at one point some of this nesting was important to avoid
cycles in the dependency graph, but that no longer seems to be the
case.
2017-11-17 20:26:33 +02:00
Jesse Rosenberger
5e4ee8dc36 Only import necessary functions from cordova, not *.
The rest of the module is not necessary.
2017-11-17 20:17:21 +02:00
Jesse Rosenberger
ecec5a1ad0 Ensure that Cordova is installed for meteor [add |remove] cordova:*.
In the same spirit as the changes made in
https://github.com/meteor/meteor/pull/8976.

Fixes: https://github.com/meteor/meteor/issues/9257.
2017-11-17 02:15:04 +02:00
Hugh Willson
27ed9bc2e8 Allow scoped Cordova packages to be installed
Fixes an issue preventing the installation of scoped Cordova
packages. For example,
`meteor add cordova:@somescope/some-cordova-plugin@1.0.0`
will now work properly.

Fixes https://github.com/meteor/meteor/issues/7336.
2017-11-17 01:58:54 +02:00
Jack Kavanagh
dd5ea2b950 can resolve private npm package when adding cordova plugin 2017-11-17 01:57:48 +02:00
Ben Newman
be094178a5 Merge branch 'devel' into release-1.6.1 2017-11-09 10:53:09 -05:00
Jesse Rosenberger
235d00e2c7 Update references to cordova_lib.raw to account for raw deprecation.
The changes made in #9213 were seemingly innocent, but when merging
I missed the fact that the 'cordova-lib' package bump was done to a new
entry on the 'dev bundle', rather than on the
`CORDOVA_DEV_BUNDLE_VERSIONS` in tools/cordova/index.js which, as of
meteor/meteor#8976, is responsible for auto-installing Cordova when it
is used rather than including it in the pre-packaged 'dev bundle'.

That mistake was fixed with 958c44ff1b and
d6adc1b3a9, but not before it caused the
Cordova tests to falsely pass on the PR since it was functionally still
testing the previous version of Cordova, 7.0.0.

Unfortunately, one of the changes in the 7.1.0 was the deprecation of an
API we use within Meteor: the `raw` API on `cordova_lib`. Luckily, as
seen on the following commit, that change was merely a re-organizational
commit and still provides us access to that API by simply removing
the `raw.` segment and accessing the various methods directly:

90b6857f4d

Never saw that deprecation message, but we certainly saw the failure in
CI: https://circleci.com/gh/meteor/meteor/10412.

With any luck, this commit/PR will fix the problem.
2017-11-08 19:20:49 -05:00
Jesse Rosenberger
c70054dff1 Remove unintented extra space in Console message. 2017-11-09 02:10:21 +02:00
Ben Newman
eb8cf102cd Update tools/tests/old/app-with-private test app. 2017-11-08 17:52:49 -05:00
Jesse Rosenberger
1d91e05264 Remove functionality behind the build farm command.
It's still possible to publish packages for different platforms by using
the `meteor publish-for-arch` command, though it's become increasingly
difficult to offer compatible versions for every circumstance due to the
wide matrix of Node.js ABI versions. This makes it unlikely that
a package built on the build farm will be appropriate for the
application which the package is consumed by, substantially reducing the
overall value of rather expensive infrastructure.

Since Meteor 1.4, and as part of the jump from Node 0.10 to Node 4,
Meteor introduced the capability to compile binary dependencies at the
time that a package is installed.  Additionally, many Node.js packages
are already pre-compiled in a much more effective and wide-spread nature
for the entire JavaScript ecosystem using tools like `node-pre-gyp`.

cc @benjamn.
2017-11-09 00:23:25 +02:00
Ben Newman
cc6b7fec23 Merge branch 'devel' into release-1.6.1 2017-11-08 15:03:22 -05:00
Jesse Rosenberger
d6adc1b3a9 Update 'cordova-lib' to the intended version, 7.1.0, not 7.1.1.
I think I just typo-ed that patch version right before I committed it.

It certainly should have been 7.1.0. :(

Ref: https://github.com/meteor/meteor/pull/9213

cc @skirunman.
2017-11-08 21:55:48 +02:00
Jesse Rosenberger
958c44ff1b Move 'cordova-lib' back to CORDOVA_DEV_BUNDLE_VERSIONS for auto install.
While 'cordova-lib' used to live in 'dev-bundle-tool-package.js' where
it was pre-bundled into the "dev bundle", that is no longer the case.

It is now automatically installed, on demand, when Cordova is used.

This follows up on meteor/meteor#9213, which added it back to the
'dev-bundle-tool-package.js' and updates it in the new location.

Ref: https://github.com/meteor/meteor/pull/9213
Ref: 073f2410a6

cc @skirunman.
2017-11-08 21:53:37 +02:00
Ben Newman
1282bc77b1 Merge branch 'devel' into release-1.6.1 2017-11-08 14:43:36 -05:00
Ben Newman
35e70fd23d Stop adding line number comments to linked JavaScript files. (#9323)
Several years ago, before all major browsers supported source maps, we
felt it was important to provide line number information in generated
files using end-of-line comments like "// 123\n".

Adding all these comments was always slower than leaving the code
unmodified, and recently they have begun interacting badly with certain
newer ECMAScript syntax, such as multi-line template strings (#9160).

Since source maps are well supported in most browsers that developers are
likely to be using for development, and the line number comments are now
causing substantive problems beyond the performance cost, I think it's
time we stopped using them once and for all.

Fixes #9160.
2017-11-08 12:04:59 -05:00
skirunman
073f2410a6 Cordova 7.1.0, Android 6.3.0 and iOS 4.5.3 updates (#9213)
* Update to Cordova 7.1.0 and Cordova Android 6.3.0

* Update deprecated Cordova plugins

* Update History.md for both Cordova updates and previous iOS icons and launch screens

* Update the PR #

* Remove change to History.md

This change is now in https://github.com/meteor/meteor/pull/9227

* Update to iOS 4.5.2

Update to new Cordova iOS 4.5.2 release. https://cordova.apache.org/announcements/2017/10/16/ios-release.html

* Update History.md for Cordova iOS 4.5.2.

* Update to Cordova iOS 4.5.3

Update to Cordova iOS 4.5.3, see https://cordova.apache.org/announcements/2017/10/31/ios-release.html

* Tweak history for update to Cordova iOS 4.5.3

* Update iOS launch screens 

Updating iOS launch screens to match what is supported in Cordova iOS 4.5.3 and remove latest iPad Pro sizes that are not supported in Xcode 9 and therefore not in Cordova iOS. See c3d24a9f02/bin/templates/scripts/cordova/lib/prepare.js
2017-11-08 18:14:12 +02:00
Ben Newman
cb3d4efea1 Simplify application global imports. 2017-11-07 15:25:43 -05:00
Ben Newman
91dacaf67a Guard against missing resolved.path in ImportScanner#_scanFile.
Should fix this problem reported by @jamesmillerburgess:
https://github.com/meteor/meteor/pull/9274#issuecomment-342397530
2017-11-07 10:30:34 -05:00
Ben Newman
54b649d5f5 Encapsulate deserialization logic in Unibuild#fromJSON method. 2017-11-06 17:14:05 -05:00
Ben Newman
081d59fa1a Avoid passing two unnecessary parameters to Unibuild#toJSON. 2017-11-06 17:12:10 -05:00
Ben Newman
60fe3a096d Encapsulate serialization logic in Unibuild#toJSON method. 2017-11-06 17:12:10 -05:00
Ben Newman
206f6b7ce4 Convert Unibuild to class and extract into own module. 2017-11-06 17:12:10 -05:00
Ben Newman
f70f3f275c Bump LINKER_CACHE_SALT after recent linker changes. 2017-11-06 16:55:31 -05:00
Ben Newman
78a7cc0633 Use PackageRegistry for build plugins, too. 2017-11-06 16:55:31 -05:00
Ben Newman
57533d2205 Use Package._define helper to initialize Package.* exports.
This saves a little bit of boilerplate code in every package.
2017-11-06 16:55:31 -05:00
Ben Newman
5ee44ca81c Initialize global.Package once, instead of in every package. 2017-11-06 16:55:31 -05:00
Ben Newman
a33ac61ea8 Remove underscore import from boot.js. 2017-11-06 16:55:31 -05:00
Ben Newman
1cbcfb59bc Update dynamic-import test app to use React 16. 2017-11-06 15:46:33 -05:00
Ben Newman
9526ce8976 Test that object-valued package.json "browser" fields are respected.
Regression test for #6890.
2017-11-06 15:46:09 -05:00
Ben Newman
d6b8648eec Add a package-lock.json file to the dynamic-import test app. 2017-11-06 15:10:38 -05:00
Ben Newman
6ada1565aa Update dynamic-import test app to Meteor 1.6. 2017-11-06 15:10:38 -05:00
Ben Newman
234fb35174 Update modules test app to Meteor 1.6. 2017-11-06 15:09:55 -05:00
Ben Newman
8d3ae25eb8 Cache Resolver methods for finding package.json data. 2017-11-06 14:09:54 -05:00
Ben Newman
71cffb2a1f Output package.json "browser" aliases in tools/isobuild/linker.js. 2017-11-06 14:09:54 -05:00
Ben Newman
edc97bad27 Register aliases from package.json "browser" field in ImportScanner. 2017-11-06 14:09:54 -05:00
Ben Newman
d4872366d0 Refactor Resolver handling of package.json files.
Any package.json file that includes an object-valued "browser" field will
now be included in the .packageJsonMap.
2017-11-06 14:09:54 -05:00